From cc53b25ba4e885bc905adae3b4d88a09fe110a59 Mon Sep 17 00:00:00 2001 From: congqixia Date: Fri, 26 Sep 2025 18:21:04 +0800 Subject: [PATCH] fix: [skip e2e] Update unit test after hnsw support binary vector (#44575) fix: #44574 --------- Signed-off-by: Congqi Xia --- .../float_vector_base_checker_test.go | 16 +++++++++------- .../util/indexparamcheck/hnsw_checker_test.go | 2 +- .../util/vecindexmgr/vector_index_mgr_test.go | 2 +- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/internal/util/indexparamcheck/float_vector_base_checker_test.go b/internal/util/indexparamcheck/float_vector_base_checker_test.go index 7306db92b0..10341cfb82 100644 --- a/internal/util/indexparamcheck/float_vector_base_checker_test.go +++ b/internal/util/indexparamcheck/float_vector_base_checker_test.go @@ -63,17 +63,19 @@ func Test_floatVectorBaseChecker_CheckValidDataType(t *testing.T) { }, { dType: schemapb.DataType_BinaryVector, - errIsNil: false, + errIsNil: true, }, } c, _ := GetIndexCheckerMgrInstance().GetChecker("HNSW") for _, test := range cases { - err := c.CheckValidDataType("HNSW", &schemapb.FieldSchema{DataType: test.dType}) - if test.errIsNil { - assert.NoError(t, err) - } else { - assert.Error(t, err) - } + t.Run(test.dType.String(), func(t *testing.T) { + err := c.CheckValidDataType("HNSW", &schemapb.FieldSchema{DataType: test.dType}) + if test.errIsNil { + assert.NoError(t, err) + } else { + assert.Error(t, err) + } + }) } } diff --git a/internal/util/indexparamcheck/hnsw_checker_test.go b/internal/util/indexparamcheck/hnsw_checker_test.go index 4ee8d1112a..f5504c689b 100644 --- a/internal/util/indexparamcheck/hnsw_checker_test.go +++ b/internal/util/indexparamcheck/hnsw_checker_test.go @@ -165,7 +165,7 @@ func Test_hnswChecker_CheckValidDataType(t *testing.T) { }, { dType: schemapb.DataType_BinaryVector, - errIsNil: false, + errIsNil: true, }, } diff --git a/internal/util/vecindexmgr/vector_index_mgr_test.go b/internal/util/vecindexmgr/vector_index_mgr_test.go index 6abcefd6a2..37513b555e 100644 --- a/internal/util/vecindexmgr/vector_index_mgr_test.go +++ b/internal/util/vecindexmgr/vector_index_mgr_test.go @@ -67,7 +67,7 @@ func Test_VecIndex_DataType_Support(t *testing.T) { schemapb.DataType_Float16Vector, schemapb.DataType_SparseFloatVector, }, - wants: []bool{true, false, true, true, false}, + wants: []bool{true, true, true, true, false}, }, { indexType: "DISKANN",