From cb9d9ec0f0205cfac28a3f6ccf96496e2bbc4e6c Mon Sep 17 00:00:00 2001 From: Cai Yudong Date: Wed, 10 Jan 2024 13:18:50 +0800 Subject: [PATCH] enhance: Correct sampleFraction's type to float (#29810) Signed-off-by: Yudong Cai --- internal/core/src/common/Tracer.h | 2 +- internal/core/src/common/type_c.h | 2 +- internal/util/initcore/init_core.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/core/src/common/Tracer.h b/internal/core/src/common/Tracer.h index 9b2aa95f8e..bb984fc435 100644 --- a/internal/core/src/common/Tracer.h +++ b/internal/core/src/common/Tracer.h @@ -21,7 +21,7 @@ namespace milvus::tracer { struct TraceConfig { std::string exporter; - int sampleFraction; + float sampleFraction; std::string jaegerURL; std::string otlpEndpoint; bool oltpSecure; diff --git a/internal/core/src/common/type_c.h b/internal/core/src/common/type_c.h index f9eed84fe7..48eb069373 100644 --- a/internal/core/src/common/type_c.h +++ b/internal/core/src/common/type_c.h @@ -92,7 +92,7 @@ typedef struct CStorageConfig { typedef struct CTraceConfig { const char* exporter; - int sampleFraction; + float sampleFraction; const char* jaegerURL; const char* otlpEndpoint; bool oltpSecure; diff --git a/internal/util/initcore/init_core.go b/internal/util/initcore/init_core.go index 9bcbca2f66..d492c28d7e 100644 --- a/internal/util/initcore/init_core.go +++ b/internal/util/initcore/init_core.go @@ -47,7 +47,7 @@ func InitLocalChunkManager(path string) { func InitTraceConfig(params *paramtable.ComponentParam) { config := C.CTraceConfig{ exporter: C.CString(params.TraceCfg.Exporter.GetValue()), - sampleFraction: C.int(params.TraceCfg.SampleFraction.GetAsInt()), + sampleFraction: C.float(params.TraceCfg.SampleFraction.GetAsFloat()), jaegerURL: C.CString(params.TraceCfg.JaegerURL.GetValue()), otlpEndpoint: C.CString(params.TraceCfg.OtlpEndpoint.GetValue()), nodeID: C.int(paramtable.GetNodeID()),