From c650240f3101db670eb12b0f11c2f4dfb2965b08 Mon Sep 17 00:00:00 2001 From: wei liu Date: Mon, 4 Dec 2023 18:52:32 +0800 Subject: [PATCH] enhance: Change some frequency log to rated level (#28897) (#28934) pr: #28897 This pr change some frequency log's level to rated. Signed-off-by: Wei Liu --- internal/querycoordv2/observers/target_observer.go | 8 +++++--- internal/querycoordv2/services.go | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/internal/querycoordv2/observers/target_observer.go b/internal/querycoordv2/observers/target_observer.go index c151aec653..0ce85548df 100644 --- a/internal/querycoordv2/observers/target_observer.go +++ b/internal/querycoordv2/observers/target_observer.go @@ -260,9 +260,10 @@ func (ob *TargetObserver) isNextTargetExpired(collectionID int64) bool { } func (ob *TargetObserver) updateNextTarget(collectionID int64) error { - log := log.With(zap.Int64("collectionID", collectionID)) + log := log.Ctx(context.TODO()).WithRateGroup("qcv2.TargetObserver", 1, 60). + With(zap.Int64("collectionID", collectionID)) - log.Info("observer trigger update next target") + log.RatedInfo(10, "observer trigger update next target") err := ob.targetMgr.UpdateCollectionNextTarget(collectionID) if err != nil { log.Warn("failed to update next target for collection", @@ -433,7 +434,8 @@ func (ob *TargetObserver) checkNeedUpdateTargetVersion(ctx context.Context, lead } func (ob *TargetObserver) updateCurrentTarget(collectionID int64) { - log.Info("observer trigger update current target", zap.Int64("collectionID", collectionID)) + log := log.Ctx(context.TODO()).WithRateGroup("qcv2.TargetObserver", 1, 60) + log.RatedInfo(10, "observer trigger update current target", zap.Int64("collectionID", collectionID)) if ob.targetMgr.UpdateCollectionCurrentTarget(collectionID) { ob.mut.Lock() defer ob.mut.Unlock() diff --git a/internal/querycoordv2/services.go b/internal/querycoordv2/services.go index c6adaf8973..2a052478fa 100644 --- a/internal/querycoordv2/services.go +++ b/internal/querycoordv2/services.go @@ -830,11 +830,11 @@ func (s *Server) GetReplicas(ctx context.Context, req *milvuspb.GetReplicasReque } func (s *Server) GetShardLeaders(ctx context.Context, req *querypb.GetShardLeadersRequest) (*querypb.GetShardLeadersResponse, error) { - log := log.Ctx(ctx).With( + log := log.Ctx(ctx).WithRateGroup("qcv2.GetShardLeaders", 1, 60).With( zap.Int64("collectionID", req.GetCollectionID()), ) - log.Info("get shard leaders request received") + log.RatedInfo(10, "get shard leaders request received") if err := merr.CheckHealthy(s.State()); err != nil { msg := "failed to get shard leaders" log.Warn(msg, zap.Error(err))