diff --git a/internal/util/distance/calc_distance.go b/internal/util/distance/calc_distance.go index 113291d4eb..8c8e04a72a 100644 --- a/internal/util/distance/calc_distance.go +++ b/internal/util/distance/calc_distance.go @@ -205,7 +205,7 @@ func CalcHammingBatch(dim int64, left []byte, lIndex int64, right []byte, result } } -func CalcHammingDistance(dim int64, left []byte, right []byte) ([]int32, error) { +func CalcHammingDistance(dim int64, left, right []byte) ([]int32, error) { if dim <= 0 { err := errors.New("Invalid dimension") return nil, err diff --git a/internal/util/paramtable/basetable.go b/internal/util/paramtable/basetable.go index 5a1ed963de..2e90ac32c1 100644 --- a/internal/util/paramtable/basetable.go +++ b/internal/util/paramtable/basetable.go @@ -313,7 +313,7 @@ func (gp *BaseTable) Load(key string) (string, error) { return gp.params.Load(strings.ToLower(key)) } -func (gp *BaseTable) LoadWithDefault(key string, defaultValue string) string { +func (gp *BaseTable) LoadWithDefault(key, defaultValue string) string { return gp.params.LoadWithDefault(strings.ToLower(key), defaultValue) } diff --git a/internal/util/trace/util.go b/internal/util/trace/util.go index eff41548af..39a27cd018 100644 --- a/internal/util/trace/util.go +++ b/internal/util/trace/util.go @@ -165,7 +165,7 @@ func LogError(span opentracing.Span, err error) { } // InfoFromSpan is a method return span details. -func InfoFromSpan(span opentracing.Span) (traceID string, sampled bool, found bool) { +func InfoFromSpan(span opentracing.Span) (traceID string, sampled, found bool) { if span != nil { if spanContext, ok := span.Context().(jaeger.SpanContext); ok { traceID = spanContext.TraceID().String() diff --git a/internal/util/typeutil/index.go b/internal/util/typeutil/index.go index 7187c11982..26b9515d15 100644 --- a/internal/util/typeutil/index.go +++ b/internal/util/typeutil/index.go @@ -16,7 +16,7 @@ import "github.com/milvus-io/milvus/internal/proto/commonpb" // CompareIndexParams compares indexParam1 with indexParam2. When all keys of indexParam1 exist in indexParam2, // and the corresponding value are the same as in indexParam2, return true // Otherwise return false -func CompareIndexParams(indexParam1 []*commonpb.KeyValuePair, indexParam2 []*commonpb.KeyValuePair) bool { +func CompareIndexParams(indexParam1, indexParam2 []*commonpb.KeyValuePair) bool { if indexParam1 == nil && indexParam2 == nil { return true } diff --git a/internal/util/typeutil/time.go b/internal/util/typeutil/time.go index 0305642722..4e5f2dce61 100644 --- a/internal/util/typeutil/time.go +++ b/internal/util/typeutil/time.go @@ -35,6 +35,6 @@ func ParseTimestamp(data []byte) (time.Time, error) { } // SubTimeByWallClock returns the duration between two different timestamps. -func SubTimeByWallClock(after time.Time, before time.Time) time.Duration { +func SubTimeByWallClock(after, before time.Time) time.Duration { return time.Duration(after.UnixNano() - before.UnixNano()) }