admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-02-04 11:18:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

Refine log of CreateCollection (#13449)

Browse Source 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
This commit is contained in:
Jiquan Long 2021-12-15 22:43:10 +08:00 committed by GitHub
parent 2423397321
commit c26341c0cd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
internal/proxy/impl.go
View File

@ -155,10 +155,12 @@ func (node *Proxy) CreateCollection(ctx context.Context, request *milvuspb.Creat
rootCoord: node.rootCoord,
}
method := "CreateCollection"
// avoid data race
lenOfSchema := len(request.Schema)
log.Debug("CreateCollection received",
log.Debug(
rpcReceived(method),
zap.String("traceID", traceID),
zap.String("role", typeutil.ProxyRole),
zap.String("db", request.DbName),
@ -166,9 +168,9 @@ func (node *Proxy) CreateCollection(ctx context.Context, request *milvuspb.Creat
zap.Int("len(schema)", lenOfSchema),
zap.Int32("shards_num", request.ShardsNum))
err := node.sched.ddQueue.Enqueue(cct)
if err != nil {
log.Debug("CreateCollection failed to enqueue",
if err := node.sched.ddQueue.Enqueue(cct); err != nil {
log.Warn(
rpcFailedToEnqueue(method),
zap.Error(err),
zap.String("traceID", traceID),
zap.String("role", typeutil.ProxyRole),
@ -183,7 +185,8 @@ func (node *Proxy) CreateCollection(ctx context.Context, request *milvuspb.Creat
}, nil
}
log.Debug("CreateCollection enqueued",
log.Debug(
rpcEnqueued(method),
zap.String("traceID", traceID),
zap.String("role", typeutil.ProxyRole),
zap.Int64("MsgID", cct.ID()),
@ -195,9 +198,9 @@ func (node *Proxy) CreateCollection(ctx context.Context, request *milvuspb.Creat
zap.Int("len(schema)", lenOfSchema),
zap.Int32("shards_num", request.ShardsNum))
err = cct.WaitToFinish()
if err != nil {
log.Debug("CreateCollection failed to WaitToFinish",
if err := cct.WaitToFinish(); err != nil {
log.Warn(
rpcFailedToWaitToFinish(method),
zap.Error(err),
zap.String("traceID", traceID),
zap.String("role", typeutil.ProxyRole),
@ -215,7 +218,8 @@ func (node *Proxy) CreateCollection(ctx context.Context, request *milvuspb.Creat
}, nil
}
log.Debug("CreateCollection done",
log.Debug(
rpcDone(method),
zap.String("traceID", traceID),
zap.String("role", typeutil.ProxyRole),
zap.Int64("MsgID", cct.ID()),