From be71b981460e70e695d7f1dc28738bca07e7e688 Mon Sep 17 00:00:00 2001 From: congqixia Date: Fri, 1 Nov 2024 14:00:22 +0800 Subject: [PATCH] enhance: Fix case error msg after knowhere upgrade (#37339) Previous PR: #37315 Error message updated after knowhere behavior change, this PR update corresponding test error message. Signed-off-by: Congqi Xia --- internal/querynodev2/delegator/delta_forward.go | 2 +- tests/go_client/testcases/index_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/querynodev2/delegator/delta_forward.go b/internal/querynodev2/delegator/delta_forward.go index e2ba923490..c88b19cb08 100644 --- a/internal/querynodev2/delegator/delta_forward.go +++ b/internal/querynodev2/delegator/delta_forward.go @@ -71,7 +71,7 @@ func (sd *shardDelegator) forwardL0Deletion(ctx context.Context, } func (sd *shardDelegator) forwardStreamingDeletion(ctx context.Context, deleteData []*DeleteData) { - // TODO add `auto` policy + // TODO @congqixia add `auto` policy // using direct when streaming size is too large // need some experimental data to support this policy switch policy := paramtable.Get().QueryNodeCfg.StreamingDeltaForwardPolicy.GetValue(); policy { diff --git a/tests/go_client/testcases/index_test.go b/tests/go_client/testcases/index_test.go index a0602c5b3b..62205321a6 100644 --- a/tests/go_client/testcases/index_test.go +++ b/tests/go_client/testcases/index_test.go @@ -1004,7 +1004,7 @@ func TestCreateIndexInvalidParams(t *testing.T) { idxIvfPq := index.NewIvfPQIndex(entity.L2, 128, 7, 8) _, err := mc.CreateIndex(ctx, client.NewCreateIndexOption(schema.CollectionName, common.DefaultFloatVecFieldName, idxIvfPq)) - common.CheckErr(t, err, false, "dimension must be able to be divided by `m`") + common.CheckErr(t, err, false, "The dimension of a vector (dim) should be a multiple of the number of subquantizers (m)") // invalid Hnsw M [1, 2048], efConstruction [1, 2147483647] for _, invalidM := range []int{0, 2049} {