From be4b0189b1dc6d3ef3baa3685642d0b67bd2f5a7 Mon Sep 17 00:00:00 2001 From: Ten Thousand Leaves <69466447+soothing-rain@users.noreply.github.com> Date: Thu, 13 Oct 2022 19:21:23 +0800 Subject: [PATCH] Fix potential long log (#19757) /kind improvement Signed-off-by: Yuchen Gao Signed-off-by: Yuchen Gao --- internal/datacoord/server.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/internal/datacoord/server.go b/internal/datacoord/server.go index 22c220834c..a357d12439 100644 --- a/internal/datacoord/server.go +++ b/internal/datacoord/server.go @@ -294,12 +294,12 @@ func (s *Server) Init() error { } // Start initialize `Server` members and start loops, follow steps are taken: -// 1. initialize message factory parameters -// 2. initialize root coord client, meta, datanode cluster, segment info channel, -// allocator, segment manager -// 3. start service discovery and server loops, which includes message stream handler (segment statistics,datanode tt) -// datanodes etcd watch, etcd alive check and flush completed status check -// 4. set server state to Healthy +// 1. initialize message factory parameters +// 2. initialize root coord client, meta, datanode cluster, segment info channel, +// allocator, segment manager +// 3. start service discovery and server loops, which includes message stream handler (segment statistics,datanode tt) +// datanodes etcd watch, etcd alive check and flush completed status check +// 4. set server state to Healthy func (s *Server) Start() error { s.compactionHandler.start() s.compactionTrigger.start() @@ -600,7 +600,6 @@ func (s *Server) updateSegmentStatistics(stats []*datapb.SegmentStats) { zap.Int64("segment ID", stat.GetSegmentID()), zap.Int64("old value", s.meta.GetAllSegment(stat.GetSegmentID()).GetNumOfRows()), zap.Int64("new value", stat.GetNumRows()), - zap.Any("seg info", s.meta.GetSegment(stat.GetSegmentID())), ) } s.meta.SetCurrentRows(stat.GetSegmentID(), stat.GetNumRows()) @@ -833,6 +832,7 @@ func (s *Server) initRootCoordClient() error { // Stop do the Server finalize processes // it checks the server status is healthy, if not, just quit // if Server is healthy, set server state to stopped, release etcd session, +// // stop message stream client and stop server loops func (s *Server) Stop() error { if !s.stateCode.CompareAndSwap(commonpb.StateCode_Healthy, commonpb.StateCode_Abnormal) {