From bb7765cbd63031a41c2ea1a69b78b9a4ee824f5c Mon Sep 17 00:00:00 2001 From: Buqian Zheng Date: Fri, 10 May 2024 11:31:30 +0800 Subject: [PATCH] fix: fix Indexing.Iterator ut: build index with all data at once (#32844) issue: #32843 Signed-off-by: Buqian Zheng --- internal/core/unittest/test_indexing.cpp | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/internal/core/unittest/test_indexing.cpp b/internal/core/unittest/test_indexing.cpp index 0d852747a2..4cdf94420b 100644 --- a/internal/core/unittest/test_indexing.cpp +++ b/internal/core/unittest/test_indexing.cpp @@ -410,11 +410,10 @@ INSTANTIATE_TEST_SUITE_P( #endif std::pair(knowhere::IndexEnum::INDEX_HNSW, knowhere::metric::L2))); -/*TEST(Indexing, Iterator) { +TEST(Indexing, Iterator) { constexpr int N = 10240; constexpr int TOPK = 100; constexpr int dim = 128; - constexpr int chunk_size = 5120; auto [raw_data, timestamps, uids] = generate_data(N); milvus::index::CreateIndexInfo create_index_info; @@ -437,21 +436,8 @@ INSTANTIATE_TEST_SUITE_P( {knowhere::indexparam::NPROBE, 4}, }; - std::vector datasets; - auto raw = raw_data.data(); - for (int beg = 0; beg < N; beg += chunk_size) { - auto end = beg + chunk_size; - if (end > N) { - end = N; - } - std::vector ft(raw + dim * beg, raw + dim * end); - auto ds = knowhere::GenDataSet(end - beg, dim, ft.data()); - datasets.push_back(ds); - } - - for (auto& ds : datasets) { - index->BuildWithDataset(ds, build_conf); - } + index->BuildWithDataset(knowhere::GenDataSet(N, dim, raw_data.data()), + build_conf); auto bitmap = BitsetType(N, false); @@ -477,7 +463,7 @@ INSTANTIATE_TEST_SUITE_P( ASSERT_TRUE(off >= 0); ASSERT_TRUE(dis >= 0); } -}*/ +} TEST_P(IndexTest, BuildAndQuery) { milvus::index::CreateIndexInfo create_index_info;