From b983ef9fcae01f9287bcf03c13de8f9a3e51dca6 Mon Sep 17 00:00:00 2001 From: wei liu Date: Thu, 21 Nov 2024 10:40:31 +0800 Subject: [PATCH] fix: Channel may be released after balance (#37862) issue: #37830 casue dist handler doesn't set channel's version, so if channel checker try to dedup channel, it may release the new delegator after balance finished. this PR fix the way to set proper version for channel. Signed-off-by: Wei Liu --- internal/querycoordv2/dist/dist_handler.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/internal/querycoordv2/dist/dist_handler.go b/internal/querycoordv2/dist/dist_handler.go index 18b6ab38a8..f1a5434f8f 100644 --- a/internal/querycoordv2/dist/dist_handler.go +++ b/internal/querycoordv2/dist/dist_handler.go @@ -181,7 +181,11 @@ func (dh *distHandler) updateChannelsDistribution(resp *querypb.GetDataDistribut Version: ch.GetVersion(), } } else { - channel = channelInfo.Clone() + channel = &meta.DmChannel{ + VchannelInfo: channelInfo.VchannelInfo, + Node: resp.GetNodeID(), + Version: ch.GetVersion(), + } } updates = append(updates, channel) }