From b897ca5703ec45c975aa84c64a6788d0ca6da6aa Mon Sep 17 00:00:00 2001 From: groot Date: Thu, 23 Sep 2021 14:19:54 +0800 Subject: [PATCH] Fix unittest build problem (#8369) Signed-off-by: yhmo --- internal/core/src/index/CMakeLists.txt | 2 +- internal/core/src/index/cmake/DefineOptionsCore.cmake | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/internal/core/src/index/CMakeLists.txt b/internal/core/src/index/CMakeLists.txt index 0180bae81f..2f3d4e1663 100644 --- a/internal/core/src/index/CMakeLists.txt +++ b/internal/core/src/index/CMakeLists.txt @@ -93,7 +93,7 @@ endif () set(INDEX_INCLUDE_DIRS ${INDEX_INCLUDE_DIRS} PARENT_SCOPE) -if (KNOWHERE_BUILD_TESTS) +if (BUILD_UNIT_TEST) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DELPP_DISABLE_LOGS") add_subdirectory(unittest) endif () diff --git a/internal/core/src/index/cmake/DefineOptionsCore.cmake b/internal/core/src/index/cmake/DefineOptionsCore.cmake index aab4603110..5d54b41f1b 100644 --- a/internal/core/src/index/cmake/DefineOptionsCore.cmake +++ b/internal/core/src/index/cmake/DefineOptionsCore.cmake @@ -91,12 +91,6 @@ define_option(MILVUS_CUDA_ARCH "Build with CUDA arch" "DEFAULT") #---------------------------------------------------------------------- set_option_category("Test and benchmark") -if (BUILD_UNIT_TEST) - define_option(KNOWHERE_BUILD_TESTS "Build the KNOWHERE googletest unit tests" ON) -else () - define_option(KNOWHERE_BUILD_TESTS "Build the KNOWHERE googletest unit tests" OFF) -endif (BUILD_UNIT_TEST) - #---------------------------------------------------------------------- macro(config_summary) message(STATUS "---------------------------------------------------------------------")