From b734de5398dbcc18121dcb970e2331b9ed85005e Mon Sep 17 00:00:00 2001
From: congqixia <congqi.xia@zilliz.com>
Date: Tue, 18 Nov 2025 15:31:39 +0800
Subject: [PATCH] fix: [skip e2e] move gRPC server start after service
 registration in zilliz client tests (#45645)

The tests were failing with "grpc: Server.RegisterService after
Server.Serve" because setupMockServer() was starting the gRPC server
before tests could register their services. gRPC requires all services
to be registered before Server.Serve() is called.

Changes:
- Remove s.Serve() from setupMockServer() helper function
- Add s.Serve() to each test after service registration
- Apply fix consistently to all 6 affected tests:
  * TestZillizClient_Embedding
  * TestZillizClient_Embedding_Error
  * TestZillizClient_Rerank
  * TestZillizClient_Rerank_Error
  * TestNewZilliClient_WithMockServer
  * TestZillizClient_Embedding_EmptyResponse

This follows the correct gRPC server lifecycle:
1. Create server
2. Register services
3. Start serving

Related to #44620
Case: "internal/util/function/models/zilliz TestZillizClient_Rerank"

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
---
 .../models/zilliz/zilliz_client_test.go       | 42 ++++++++++++++++---
 1 file changed, 36 insertions(+), 6 deletions(-)

diff --git a/internal/util/function/models/zilliz/zilliz_client_test.go b/internal/util/function/models/zilliz/zilliz_client_test.go
index bb160504fc..c3a87e69fb 100644
--- a/internal/util/function/models/zilliz/zilliz_client_test.go
+++ b/internal/util/function/models/zilliz/zilliz_client_test.go
@@ -205,12 +205,6 @@ func setupMockServer(t *testing.T) (*grpc.Server, *bufconn.Listener, func(contex
 		return lis.Dial()
 	}
 
-	go func() {
-		if err := s.Serve(lis); err != nil {
-			t.Logf("Server exited with error: %v", err)
-		}
-	}()
-
 	return s, lis, dialer
 }
 
@@ -269,6 +263,12 @@ func TestZillizClient_Embedding(t *testing.T) {
 
 	modelservicepb.RegisterTextEmbeddingServiceServer(s, mockServer)
 
+	go func() {
+		if err := s.Serve(lis); err != nil {
+			t.Logf("Server exited with error: %v", err)
+		}
+	}()
+
 	// Create connection
 	conn, err := grpc.DialContext(
 		context.Background(),
@@ -310,6 +310,12 @@ func TestZillizClient_Embedding_Error(t *testing.T) {
 
 	modelservicepb.RegisterTextEmbeddingServiceServer(s, mockServer)
 
+	go func() {
+		if err := s.Serve(lis); err != nil {
+			t.Logf("Server exited with error: %v", err)
+		}
+	}()
+
 	// Create connection
 	conn, err := grpc.DialContext(
 		context.Background(),
@@ -352,6 +358,12 @@ func TestZillizClient_Rerank(t *testing.T) {
 
 	modelservicepb.RegisterRerankServiceServer(s, mockServer)
 
+	go func() {
+		if err := s.Serve(lis); err != nil {
+			t.Logf("Server exited with error: %v", err)
+		}
+	}()
+
 	// Create connection
 	conn, err := grpc.DialContext(
 		context.Background(),
@@ -392,6 +404,12 @@ func TestZillizClient_Rerank_Error(t *testing.T) {
 
 	modelservicepb.RegisterRerankServiceServer(s, mockServer)
 
+	go func() {
+		if err := s.Serve(lis); err != nil {
+			t.Logf("Server exited with error: %v", err)
+		}
+	}()
+
 	// Create connection
 	conn, err := grpc.DialContext(
 		context.Background(),
@@ -463,6 +481,12 @@ func TestNewZilliClient_WithMockServer(t *testing.T) {
 	defer s.Stop()
 	defer lis.Close()
 
+	go func() {
+		if err := s.Serve(lis); err != nil {
+			t.Logf("Server exited with error: %v", err)
+		}
+	}()
+
 	// We need to test the client creation with a working connection
 	// Since NewZilliClient uses the global client manager, we need to test it differently
 	t.Run("valid config with mock server", func(t *testing.T) {
@@ -502,6 +526,12 @@ func TestZillizClient_Embedding_EmptyResponse(t *testing.T) {
 
 	modelservicepb.RegisterTextEmbeddingServiceServer(s, mockServer)
 
+	go func() {
+		if err := s.Serve(lis); err != nil {
+			t.Logf("Server exited with error: %v", err)
+		}
+	}()
+
 	// Create connection
 	conn, err := grpc.DialContext(
 		context.Background(),