admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-02-02 01:06:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

Rename getEntityByIds to retrieve (#11548)

Browse Source 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
This commit is contained in:
Cai Yudong 2021-11-10 17:15:37 +08:00 committed by GitHub
parent 4df4dc8f80
commit b5bc9b26d7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/querynode/historical.go
View File

@ -217,7 +217,7 @@ func (h *historical) retrieve(collID UniqueID, partIDs []UniqueID, vcm storage.C
if err != nil {
return retrieveResults, retrieveSegmentIDs, err
}
result, err := seg.getEntityByIds(plan)
result, err := seg.retrieve(plan)
if err != nil {
return retrieveResults, retrieveSegmentIDs, err
}

2
internal/querynode/segment.go
View File

@ -312,7 +312,7 @@ func (s *Segment) search(plan *SearchPlan,
return &searchResult, nil
}
func (s *Segment) getEntityByIds(plan *RetrievePlan) (*segcorepb.RetrieveResults, error) {
func (s *Segment) retrieve(plan *RetrievePlan) (*segcorepb.RetrieveResults, error) {
s.segPtrMu.RLock()
defer s.segPtrMu.RUnlock()
if s.segmentPtr == nil {

2
internal/querynode/segment_test.go
View File

@ -225,7 +225,7 @@ func TestSegment_retrieve(t *testing.T) {
defer plan.delete()
assert.NoError(t, err)
res, err := segment.getEntityByIds(plan)
res, err := segment.retrieve(plan)
assert.NoError(t, err)
assert.Equal(t, res.GetFieldsData()[0].GetScalars().Data.(*schemapb.ScalarField_IntData).IntData.Data, []int32{1, 2, 3})

2
internal/querynode/streaming.go
View File

@ -83,7 +83,7 @@ func (s *streaming) retrieve(collID UniqueID, partIDs []UniqueID, plan *Retrieve
if err != nil {
return retrieveResults, retrieveSegmentIDs, err
}
result, err := seg.getEntityByIds(plan)
result, err := seg.retrieve(plan)
if err != nil {
return retrieveResults, retrieveSegmentIDs, err
}