Add grpc retry policy (#14241)

Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
This commit is contained in:
Bingyi Sun 2021-12-25 18:52:28 +08:00 committed by GitHub
parent 73c5653c76
commit b43a5493e8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -6,8 +6,6 @@ import (
"sync" "sync"
"time" "time"
grpcmiddleware "github.com/grpc-ecosystem/go-grpc-middleware"
grpcretry "github.com/grpc-ecosystem/go-grpc-middleware/retry"
grpcopentracing "github.com/grpc-ecosystem/go-grpc-middleware/tracing/opentracing" grpcopentracing "github.com/grpc-ecosystem/go-grpc-middleware/tracing/opentracing"
"github.com/milvus-io/milvus/internal/log" "github.com/milvus-io/milvus/internal/log"
"github.com/milvus-io/milvus/internal/util/funcutil" "github.com/milvus-io/milvus/internal/util/funcutil"
@ -15,7 +13,6 @@ import (
"go.uber.org/zap" "go.uber.org/zap"
"google.golang.org/grpc" "google.golang.org/grpc"
"google.golang.org/grpc/backoff" "google.golang.org/grpc/backoff"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/keepalive" "google.golang.org/grpc/keepalive"
) )
@ -121,6 +118,20 @@ func (c *ClientBase) connect(ctx context.Context) error {
opts := trace.GetInterceptorOpts() opts := trace.GetInterceptorOpts()
dialContext, cancel := context.WithTimeout(ctx, dialTimeout) dialContext, cancel := context.WithTimeout(ctx, dialTimeout)
retryPolicy := `{
"methodConfig": [{
"name": [{}],
"waitForReady": true,
"retryPolicy": {
"MaxAttempts": 4,
"InitialBackoff": ".1s",
"MaxBackoff": ".4s",
"BackoffMultiplier": 1.6,
"RetryableStatusCodes": [ "UNAVAILABLE" ]
}
}]}`
conn, err := grpc.DialContext( conn, err := grpc.DialContext(
dialContext, dialContext,
addr, addr,
@ -128,22 +139,11 @@ func (c *ClientBase) connect(ctx context.Context) error {
grpc.WithBlock(), grpc.WithBlock(),
grpc.WithDefaultCallOptions( grpc.WithDefaultCallOptions(
grpc.MaxCallRecvMsgSize(c.ClientMaxRecvSize), grpc.MaxCallRecvMsgSize(c.ClientMaxRecvSize),
grpc.MaxCallSendMsgSize(c.ClientMaxSendSize)), grpc.MaxCallSendMsgSize(c.ClientMaxSendSize),
grpc.WithUnaryInterceptor(
grpcmiddleware.ChainUnaryClient(
grpcretry.UnaryClientInterceptor(
grpcretry.WithMax(3),
grpcretry.WithCodes(codes.Aborted, codes.Unavailable),
), ),
grpcopentracing.UnaryClientInterceptor(opts...), grpc.WithUnaryInterceptor(grpcopentracing.UnaryClientInterceptor(opts...)),
)), grpc.WithStreamInterceptor(grpcopentracing.StreamClientInterceptor(opts...)),
grpc.WithStreamInterceptor( grpc.WithDefaultServiceConfig(retryPolicy),
grpcmiddleware.ChainStreamClient(
grpcretry.StreamClientInterceptor(grpcretry.WithMax(3),
grpcretry.WithCodes(codes.Aborted, codes.Unavailable),
),
grpcopentracing.StreamClientInterceptor(opts...),
)),
grpc.WithKeepaliveParams(keepalive.ClientParameters{ grpc.WithKeepaliveParams(keepalive.ClientParameters{
Time: keepAliveTime, // send pings every 60 seconds if there is no activity Time: keepAliveTime, // send pings every 60 seconds if there is no activity
Timeout: keepAliveTimeout, // wait 6 second for ping ack before considering the connection dead Timeout: keepAliveTimeout, // wait 6 second for ping ack before considering the connection dead