admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-06 17:18:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Group value is nil(#45418) (#45421)

Browse Source 
related: #45418
pr: https://github.com/milvus-io/milvus/pull/45422

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
This commit is contained in:
Chun Han 2025-11-08 10:27:34 +08:00 committed by GitHub
parent 8a23cdb081
commit b0e490b879
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/proxy/search_reduce_util.go
View File

@ -514,6 +514,7 @@ func reduceResults(ctx context.Context, toReduceResults []*internalpb.SearchResu
} }
if len(validSearchResults) <= 0 { if len(validSearchResults) <= 0 {
log.Debug("reduced search results is empty, fill in empty result")
return fillInEmptyResult(nq), nil return fillInEmptyResult(nq), nil
} }

4
internal/util/function/rerank/util.go
View File

@ -25,6 +25,7 @@ import (
"strings" "strings"
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb" "github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
"github.com/milvus-io/milvus/pkg/v2/log"
"github.com/milvus-io/milvus/pkg/v2/util/merr" "github.com/milvus-io/milvus/pkg/v2/util/merr"
"github.com/milvus-io/milvus/pkg/v2/util/metric" "github.com/milvus-io/milvus/pkg/v2/util/metric"
"github.com/milvus-io/milvus/pkg/v2/util/typeutil" "github.com/milvus-io/milvus/pkg/v2/util/typeutil"
@ -516,7 +517,8 @@ func genIdGroupingMap(multipSearchResultData []*schemapb.SearchResultData) (map[
idGroupValue := map[any]any{} idGroupValue := map[any]any{}
for _, result := range multipSearchResultData { for _, result := range multipSearchResultData {
if result.GetGroupByFieldValue() == nil { if result.GetGroupByFieldValue() == nil {
return nil, fmt.Errorf("Group value is nil") log.Warn("Group value is nil, this is due to empty results in search reduce phase")
continue
} }
size := typeutil.GetSizeOfIDs(result.Ids) size := typeutil.GetSizeOfIDs(result.Ids)
groupIter := typeutil.GetDataIterator(result.GetGroupByFieldValue()) groupIter := typeutil.GetDataIterator(result.GetGroupByFieldValue())