From ae2864639e69081440a6d10fcbfd544ccef6881c Mon Sep 17 00:00:00 2001
From: congqixia <congqi.xia@zilliz.com>
Date: Thu, 19 May 2022 14:53:56 +0800
Subject: [PATCH] Fix replica freeAll order (#17106)

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
---
 internal/querynode/query_node.go | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/internal/querynode/query_node.go b/internal/querynode/query_node.go
index c8006d7362..6522e71ba2 100644
--- a/internal/querynode/query_node.go
+++ b/internal/querynode/query_node.go
@@ -397,23 +397,19 @@ func (node *QueryNode) Stop() error {
 	if node.dataSyncService != nil {
 		node.dataSyncService.close()
 	}
-	if node.historical != nil {
-		node.historical.close()
-	}
+
+	// release streaming first for query/search holds query lock in streaming collection
 	if node.streaming != nil {
 		node.streaming.close()
 	}
-	/*
-		if node.queryService != nil {
-			node.queryService.close()
-		}*/
+	if node.historical != nil {
+		node.historical.close()
+	}
 
 	if node.queryShardService != nil {
 		node.queryShardService.close()
 	}
-	//if node.statsService != nil {
-	//	node.statsService.close()
-	//}
+
 	node.session.Revoke(time.Second)
 	node.wg.Wait()
 	return nil