From adf9530ed707efed47600f5d66e3617d73de9bae Mon Sep 17 00:00:00 2001 From: yukun Date: Tue, 23 Nov 2021 10:57:16 +0800 Subject: [PATCH] Bool expr not support numerica (#12184) Signed-off-by: fishpenguin --- internal/proxy/plan_parser.go | 11 ----------- internal/proxy/plan_parser_test.go | 7 +++---- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/internal/proxy/plan_parser.go b/internal/proxy/plan_parser.go index 3ffe56c819..f224885aa9 100644 --- a/internal/proxy/plan_parser.go +++ b/internal/proxy/plan_parser.go @@ -567,17 +567,6 @@ func (pc *parserContext) handleLeafValue(nodeRaw *ant_ast.Node, dataType schemap Int64Val: int64(node.Value), }, } - } else if dataType == schemapb.DataType_Bool { - gv = &planpb.GenericValue{ - Val: &planpb.GenericValue_BoolVal{}, - } - if node.Value == 1 { - gv.Val.(*planpb.GenericValue_BoolVal).BoolVal = true - } else if node.Value == 0 { - gv.Val.(*planpb.GenericValue_BoolVal).BoolVal = false - } else { - return nil, fmt.Errorf("bool field should only match 0 or 1") - } } else { return nil, fmt.Errorf("type mismatch") } diff --git a/internal/proxy/plan_parser_test.go b/internal/proxy/plan_parser_test.go index a19d936d69..57bcfe9433 100644 --- a/internal/proxy/plan_parser_test.go +++ b/internal/proxy/plan_parser_test.go @@ -250,12 +250,11 @@ func TestExprMultiRange_Str(t *testing.T) { "BoolN1 == True", "True == BoolN1", "BoolN1 == False", - "BoolN1 == 1", - "BoolN1 == 0", } invalidExprs := []string{ - "BoolN1 == 2", - "BoolN1 > 2", + "BoolN1 == 1", + "BoolN1 == 0", + "BoolN1 > 0", } fields := []*schemapb.FieldSchema{