From 2aa6af2fd8ede0e882c2738c62f5adc41eebface Mon Sep 17 00:00:00 2001 From: groot Date: Tue, 12 Nov 2019 10:45:49 +0800 Subject: [PATCH 1/2] #284 Change C++ SDK to shread library --- CHANGELOG.md | 1 + core/src/config.h | 20 ++++++++++++++++++++ core/src/sdk/CMakeLists.txt | 2 +- 3 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 core/src/config.h diff --git a/CHANGELOG.md b/CHANGELOG.md index 1ae461f4ee..1087c1b0e0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ Please mark all change in change log and use the ticket from JIRA. - \#204 - improve grpc performance in search - \#207 - Add more unittest for config set/get - \#208 - optimize unittest to support run single test more easily +- \#284 - Change C++ SDK to shread library ## Task diff --git a/core/src/config.h b/core/src/config.h new file mode 100644 index 0000000000..745e6c5a64 --- /dev/null +++ b/core/src/config.h @@ -0,0 +1,20 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#define MILVUS_VERSION "0.6.0" +#define BUILD_TYPE "Debug" +#define BUILD_TIME "2019-11-12 10:25.02" diff --git a/core/src/sdk/CMakeLists.txt b/core/src/sdk/CMakeLists.txt index c68712d34c..71a03c38d0 100644 --- a/core/src/sdk/CMakeLists.txt +++ b/core/src/sdk/CMakeLists.txt @@ -22,7 +22,7 @@ include_directories(include) aux_source_directory(interface interface_files) aux_source_directory(grpc grpc_client_files) -add_library(milvus_sdk STATIC +add_library(milvus_sdk SHARED ${interface_files} ${grpc_client_files} ${grpc_service_files} From a1ae44e602928efa0329db0ab8e7f99c108a8076 Mon Sep 17 00:00:00 2001 From: groot Date: Tue, 12 Nov 2019 10:48:44 +0800 Subject: [PATCH 2/2] #284 Change C++ SDK to shread library --- core/src/config.h | 20 -------------------- 1 file changed, 20 deletions(-) delete mode 100644 core/src/config.h diff --git a/core/src/config.h b/core/src/config.h deleted file mode 100644 index 745e6c5a64..0000000000 --- a/core/src/config.h +++ /dev/null @@ -1,20 +0,0 @@ -// Licensed to the Apache Software Foundation (ASF) under one -// or more contributor license agreements. See the NOTICE file -// distributed with this work for additional information -// regarding copyright ownership. The ASF licenses this file -// to you under the Apache License, Version 2.0 (the -// "License"); you may not use this file except in compliance -// with the License. You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, -// software distributed under the License is distributed on an -// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -// KIND, either express or implied. See the License for the -// specific language governing permissions and limitations -// under the License. - -#define MILVUS_VERSION "0.6.0" -#define BUILD_TYPE "Debug" -#define BUILD_TIME "2019-11-12 10:25.02"