admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix index bug caused by json parse (#3129)

Browse Source 
* fix index bug caused by json parse

Signed-off-by: godchen0212 <qingxiang.chen@zilliz.com>
This commit is contained in:
chen qingxiang 2020-08-05 16:24:47 +08:00 committed by GitHub
parent 3dfbe61422
commit aad8f82d41
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/src/server/delivery/request/CreateIndexReq.cpp
View File

@ -104,7 +104,7 @@ CreateIndexReq::OnExecute() {
}
// validate index parameters
status = ValidateIndexParams(json_params_, dimension, index_type);
status = ValidateIndexParams(json_params_[engine::PARAM_INDEX_EXTRA_PARAMS], dimension, index_type);
if (!status.ok()) {
return status;
}

4
core/src/server/grpc_impl/GrpcRequestHandler.cpp
View File

@ -813,7 +813,9 @@ GrpcRequestHandler::CreateIndex(::grpc::ServerContext* context, const ::milvus::
for (int i = 0; i < request->extra_params_size(); i++) {
const ::milvus::grpc::KeyValuePair& extra = request->extra_params(i);
if (extra.key() == EXTRA_PARAM_KEY) {
json_params = json::parse(extra.value());
json_params[EXTRA_PARAM_KEY] = json::parse(extra.value());
} else {
json_params[extra.key()] = extra.value();
}
}

6
tests/milvus_python_test/collection/test_collection_count.py
View File

@ -306,7 +306,7 @@ class TestCollectionCountBinary:
connect.create_partition(binary_collection, tag)
res_ids = connect.insert(binary_collection, entities, partition_tag=tag)
connect.flush([binary_collection])
res = connect.count_entities(binary_collections)
res = connect.count_entities(binary_collection)
assert res == insert_count
@pytest.mark.level(2)
@ -510,7 +510,7 @@ class TestCollectionMultiCollections:
for i in range(collection_num):
collection_name = gen_unique_str(collection_id)
collection_list.append(collection_name)
connect.create_collection(collection_name, fields)
connect.create_collection(collection_name, default_fields)
res = connect.insert(collection_name, entities)
connect.flush(collection_list)
for i in range(collection_num):
@ -535,7 +535,7 @@ class TestCollectionMultiCollections:
for i in range(int(collection_num / 2), collection_num):
collection_name = gen_unique_str(collection_id)
collection_list.append(collection_name)
connect.create_collection(collection_name, fields)
connect.create_collection(collection_name, default_fields)
res = connect.insert(collection_name, binary_entities)
connect.flush(collection_list)
for i in range(collection_num):