From aa66072a1c5b48e7db4b826ef606b92d655db211 Mon Sep 17 00:00:00 2001 From: wei liu Date: Tue, 3 Jun 2025 17:38:32 +0800 Subject: [PATCH] enhance: Remove inadvertently introduced goccy/go-json dependency (#42146) Remove the 'goccy/go-json' library, which was inadvertently introduced, and revert to using the standard internal JSON handling. Changes include: - Removed dependency on 'github.com/goccy/go-json' in go.mod and go.sum. - Replaced import of 'goccy/go-json' with 'internal/json' in 'internal/querycoordv2/task/scheduler.go'. This correction ensures the project continues to use the intended JSON processing libraries and avoids unnecessary external dependencies. Signed-off-by: Wei Liu --- go.mod | 2 +- internal/querycoordv2/task/scheduler.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/go.mod b/go.mod index 9ef85beb15..11e0e9cd1a 100644 --- a/go.mod +++ b/go.mod @@ -66,7 +66,6 @@ require ( github.com/bytedance/sonic v1.13.2 github.com/cenkalti/backoff/v4 v4.2.1 github.com/cockroachdb/redact v1.1.3 - github.com/goccy/go-json v0.10.3 github.com/google/uuid v1.6.0 github.com/greatroar/blobloom v0.0.0-00010101000000-000000000000 github.com/hashicorp/golang-lru/v2 v2.0.7 @@ -152,6 +151,7 @@ require ( github.com/go-ole/go-ole v1.2.6 // indirect github.com/go-playground/locales v0.14.1 // indirect github.com/go-playground/universal-translator v0.18.1 // indirect + github.com/goccy/go-json v0.10.3 // indirect github.com/godbus/dbus v0.0.0-20190726142602-4481cbc300e2 // indirect github.com/godbus/dbus/v5 v5.0.4 // indirect github.com/gogo/protobuf v1.3.2 // indirect diff --git a/internal/querycoordv2/task/scheduler.go b/internal/querycoordv2/task/scheduler.go index 85f92896ef..c11c697af5 100644 --- a/internal/querycoordv2/task/scheduler.go +++ b/internal/querycoordv2/task/scheduler.go @@ -23,12 +23,12 @@ import ( "time" "github.com/cockroachdb/errors" - "github.com/goccy/go-json" "github.com/hashicorp/golang-lru/v2/expirable" "github.com/samber/lo" "go.uber.org/atomic" "go.uber.org/zap" + "github.com/milvus-io/milvus/internal/json" "github.com/milvus-io/milvus/internal/querycoordv2/meta" "github.com/milvus-io/milvus/internal/querycoordv2/session" "github.com/milvus-io/milvus/internal/querycoordv2/utils"