admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 03:13:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: create new HybridSearch request in case of data race (#29771)

Browse Source 
Resolves: #29770

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2024-01-09 09:54:48 +08:00 committed by GitHub
parent 3d07b6682c
commit a903ae641b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/integration/hybridsearch/hybridsearch_test.go
View File

@ -192,17 +192,23 @@ func (s *HybridSearchSuite) TestHybridSearch() {
searchResult, err := c.Proxy.HybridSearch(ctx, hSearchReq)
if searchResult.GetStatus().GetErrorCode() != commonpb.ErrorCode_Success {
log.Warn("searchResult fail reason", zap.String("reason", searchResult.GetStatus().GetReason()))
}
s.NoError(err)
s.Equal(commonpb.ErrorCode_Success, searchResult.GetStatus().GetErrorCode())
s.NoError(merr.CheckRPCCall(searchResult, err))
// weighted rank hybrid search
weightsParams := make(map[string][]float64)
weightsParams[proxy.WeightsParamsKey] = []float64{0.5, 0.2}
b, err = json.Marshal(weightsParams)
s.NoError(err)
// create a new request preventing data race
hSearchReq = &milvuspb.HybridSearchRequest{
Base: nil,
DbName: dbName,
CollectionName: collectionName,
PartitionNames: nil,
Requests: []*milvuspb.SearchRequest{fSearchReq, bSearchReq},
OutputFields: []string{integration.FloatVecField, integration.BinVecField},
}
hSearchReq.RankParams = []*commonpb.KeyValuePair{
{Key: proxy.RankTypeKey, Value: "weighted"},
{Key: proxy.RankParamsKey, Value: string(b)},
@ -211,11 +217,7 @@ func (s *HybridSearchSuite) TestHybridSearch() {
searchResult, err = c.Proxy.HybridSearch(ctx, hSearchReq)
if searchResult.GetStatus().GetErrorCode() != commonpb.ErrorCode_Success {
log.Warn("searchResult fail reason", zap.String("reason", searchResult.GetStatus().GetReason()))
}
s.NoError(err)
s.Equal(commonpb.ErrorCode_Success, searchResult.GetStatus().GetErrorCode())
s.NoError(merr.CheckRPCCall(searchResult, err))
log.Info("TestHybridSearch succeed")
}