From a38a0deb437a9ba0f41f76d14926a51ae428b55d Mon Sep 17 00:00:00 2001 From: aoiasd <45024769+aoiasd@users.noreply.github.com> Date: Mon, 10 Nov 2025 11:37:35 +0800 Subject: [PATCH] enhance: prevent panic by adding null pointer check when clearing InsertRecord _pk2offset_ (#45281) Signed-off-by: aoiasd --- internal/core/src/segcore/InsertRecord.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/internal/core/src/segcore/InsertRecord.h b/internal/core/src/segcore/InsertRecord.h index c18c3cc35c..80a34f0ba4 100644 --- a/internal/core/src/segcore/InsertRecord.h +++ b/internal/core/src/segcore/InsertRecord.h @@ -593,7 +593,10 @@ class InsertRecordSealed { clear() { timestamps_.clear(); timestamp_index_ = TimestampIndex(); - pk2offset_->clear(); + if (pk2offset_) { + pk2offset_->clear(); + } + reserved = 0; if (estimated_memory_size_ > 0) { cachinglayer::Manager::GetInstance().RefundLoadedResource( @@ -753,7 +756,9 @@ class InsertRecordGrowing { clear() { timestamps_.clear(); timestamp_index_ = TimestampIndex(); - pk2offset_->clear(); + if (pk2offset_) { + pk2offset_->clear(); + } reserved = 0; data_.clear(); ack_responder_.clear();