From a1db0fc40672493776c220f3b121ef79c507e4e8 Mon Sep 17 00:00:00 2001 From: congqixia Date: Fri, 8 Mar 2024 14:33:00 +0800 Subject: [PATCH] enhance: Set log level to INFO for integration test (#31136) - Set log level to INFO for integration test - Improve hello_milvus integration test runtime and error check Signed-off-by: Congqi Xia --- .../hellomilvus/hello_milvus_test.go | 18 ++++++++++++++---- tests/integration/suite.go | 3 +++ 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/tests/integration/hellomilvus/hello_milvus_test.go b/tests/integration/hellomilvus/hello_milvus_test.go index 80b4e6d1d9..3ac192d02a 100644 --- a/tests/integration/hellomilvus/hello_milvus_test.go +++ b/tests/integration/hellomilvus/hello_milvus_test.go @@ -31,6 +31,7 @@ import ( "github.com/milvus-io/milvus/pkg/common" "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/util/funcutil" + "github.com/milvus-io/milvus/pkg/util/merr" "github.com/milvus-io/milvus/pkg/util/metric" "github.com/milvus-io/milvus/tests/integration" ) @@ -146,11 +147,20 @@ func (s *HelloMilvusSuite) TestHelloMilvus() { searchResult, err := c.Proxy.Search(ctx, searchReq) - if searchResult.GetStatus().GetErrorCode() != commonpb.ErrorCode_Success { - log.Warn("searchResult fail reason", zap.String("reason", searchResult.GetStatus().GetReason())) - } + err = merr.CheckRPCCall(searchResult, err) + s.NoError(err) + + status, err := c.Proxy.ReleaseCollection(ctx, &milvuspb.ReleaseCollectionRequest{ + CollectionName: collectionName, + }) + err = merr.CheckRPCCall(status, err) + s.NoError(err) + + status, err = c.Proxy.DropCollection(ctx, &milvuspb.DropCollectionRequest{ + CollectionName: collectionName, + }) + err = merr.CheckRPCCall(status, err) s.NoError(err) - s.Equal(commonpb.ErrorCode_Success, searchResult.GetStatus().GetErrorCode()) log.Info("TestHelloMilvus succeed") } diff --git a/tests/integration/suite.go b/tests/integration/suite.go index cba27d249d..a8ad591195 100644 --- a/tests/integration/suite.go +++ b/tests/integration/suite.go @@ -25,7 +25,9 @@ import ( "github.com/stretchr/testify/suite" "go.etcd.io/etcd/server/v3/embed" + "go.uber.org/zap/zapcore" + "github.com/milvus-io/milvus/pkg/log" "github.com/milvus-io/milvus/pkg/util/etcd" "github.com/milvus-io/milvus/pkg/util/paramtable" ) @@ -80,6 +82,7 @@ func (s *MiniClusterSuite) TearDownSuite() { } func (s *MiniClusterSuite) SetupTest() { + log.SetLevel(zapcore.InfoLevel) s.T().Log("Setup test...") // setup mini cluster to use embed etcd endpoints := etcd.GetEmbedEtcdEndpoints(s.EtcdServer)