From 998ebcce4eb5e15c90414b5f4ed4348ce4e76de7 Mon Sep 17 00:00:00 2001 From: congqixia Date: Mon, 10 Jan 2022 11:53:34 +0800 Subject: [PATCH] Fix file not close when ReadAll returns error in local chunk manager (#15068) Signed-off-by: Congqi Xia --- internal/storage/local_chunk_manager.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/storage/local_chunk_manager.go b/internal/storage/local_chunk_manager.go index 6f076ce78f..b83b3b7780 100644 --- a/internal/storage/local_chunk_manager.go +++ b/internal/storage/local_chunk_manager.go @@ -82,11 +82,12 @@ func (lcm *LocalChunkManager) Read(key string) ([]byte, error) { if err != nil { return nil, err } + defer file.Close() content, err := ioutil.ReadAll(file) if err != nil { return nil, err } - return content, file.Close() + return content, nil } // ReadAt reads specific position data of local storage if exists.