From 98b32f3eba2d4ee8a6d421e006c370b6746f67ca Mon Sep 17 00:00:00 2001 From: xige-16 Date: Wed, 15 Jun 2022 20:48:10 +0800 Subject: [PATCH] Improve time record log in search/query (#17545) Signed-off-by: xige-16 --- internal/querynode/impl.go | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/internal/querynode/impl.go b/internal/querynode/impl.go index 4b26d10867..1b8a905ccc 100644 --- a/internal/querynode/impl.go +++ b/internal/querynode/impl.go @@ -460,8 +460,12 @@ func (node *QueryNode) Search(ctx context.Context, req *queryPb.SearchRequest) ( return failRet, nil } - tr := timerecord.NewTimeRecorder(fmt.Sprintf("start do search, msgID = %d, fromSharedLeader = %t, vChannel = %s, segmentIDs = %v", - msgID, req.GetFromShardLeader(), req.GetDmlChannel(), req.GetSegmentIDs())) + log.Debug("start do search", + zap.Int64("msgID", msgID), + zap.Bool("fromShardLeader", req.GetFromShardLeader()), + zap.String("vChannel", req.GetDmlChannel()), + zap.Int64s("segmentIDs", req.GetSegmentIDs())) + tr := timerecord.NewTimeRecorder("") if req.FromShardLeader { historicalTask, err2 := newSearchTask(ctx, req) @@ -640,8 +644,12 @@ func (node *QueryNode) Query(ctx context.Context, req *queryPb.QueryRequest) (*i return failRet, nil } - tr := timerecord.NewTimeRecorder(fmt.Sprintf("start do query, msgID = %d, fromSharedLeader = %t, vChannel = %s, segmentIDs = %v", - msgID, req.GetFromShardLeader(), req.GetDmlChannel(), req.GetSegmentIDs())) + log.Debug("start do query", + zap.Int64("msgID", msgID), + zap.Bool("fromShardLeader", req.GetFromShardLeader()), + zap.String("vChannel", req.GetDmlChannel()), + zap.Int64s("segmentIDs", req.GetSegmentIDs())) + tr := timerecord.NewTimeRecorder("") if req.FromShardLeader { // construct a queryTask