From 970bf18a49ca3d46762dc12ea013aff201b7003f Mon Sep 17 00:00:00 2001
From: congqixia <congqi.xia@zilliz.com>
Date: Fri, 24 May 2024 18:07:41 +0800
Subject: [PATCH] fix: Allocate new slice for each batch in streaming reader
 (#33359)

Related to #33268

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
---
 internal/storage/serde.go | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/internal/storage/serde.go b/internal/storage/serde.go
index ba5256c6d1..c75bf5aabc 100644
--- a/internal/storage/serde.go
+++ b/internal/storage/serde.go
@@ -588,9 +588,8 @@ func (deser *DeserializeReader[T]) Next() error {
 		deser.pos = 0
 		deser.rec = deser.rr.Record()
 
-		if deser.values == nil {
-			deser.values = make([]T, deser.rec.Len())
-		}
+		// allocate new slice preventing overwrite previous batch
+		deser.values = make([]T, deser.rec.Len())
 		if err := deser.deserializer(deser.rec, deser.values); err != nil {
 			return err
 		}