diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f22dae7b3..a3f4ee1fab 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,10 +5,14 @@ Please mark all change in change log and use the issue from GitHub # Milvus 1.1.1 (TBD) ## Bug - \#4897 Query results contain some deleted ids +- \#5115 Relax restrictions on topk from 16384 to 1M for CPU search - \#5164 Exception should be raised if insert or delete entity on the none-existed partition - \#5191 Mishards throw "index out of range" error after continually search/insert for a period of time +- \#5398 Random crash after request is executed - \#5537 Failed to load bloom filter after suddenly power off +- \#5544 Relax restrictions on index_file_size from 4GB to 128Gb - \#5574 IVF_SQ8 and IVF_PQ cannot be built on multiple GPUs +- \#5747 Search with big nq and topk crash milvus ## Feature - \#1434 Storage: enabling s3 storage support (implemented by Unisinsight) diff --git a/core/src/server/delivery/request/BaseRequest.cpp b/core/src/server/delivery/request/BaseRequest.cpp index 4d3484b1f4..8e0e0978bf 100644 --- a/core/src/server/delivery/request/BaseRequest.cpp +++ b/core/src/server/delivery/request/BaseRequest.cpp @@ -108,8 +108,8 @@ BaseRequest::Execute() { Status BaseRequest::PostExecute() { - status_ = OnPostExecute(); - return status_; + // not allow assign status_ here, because PostExecute() and Execute() are running on different threads + return OnPostExecute(); } Status diff --git a/core/src/server/delivery/request/BaseRequest.h b/core/src/server/delivery/request/BaseRequest.h index 083f5b61f0..fd3eacc767 100644 --- a/core/src/server/delivery/request/BaseRequest.h +++ b/core/src/server/delivery/request/BaseRequest.h @@ -213,12 +213,12 @@ class BaseRequest { RequestType type_; std::string request_group_; bool async_; - Status status_; private: mutable std::mutex finish_mtx_; std::condition_variable finish_cond_; bool done_; + Status status_; public: const std::shared_ptr&