From 951c312ef9e7e60afa5146ff94ecc128d12f2032 Mon Sep 17 00:00:00 2001 From: wei liu Date: Wed, 5 Jul 2023 17:00:25 +0800 Subject: [PATCH] refine grafana metrics for replica selection (#25319) Signed-off-by: Wei Liu --- internal/proxy/look_aside_balancer.go | 2 +- pkg/metrics/proxy_metrics.go | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/internal/proxy/look_aside_balancer.go b/internal/proxy/look_aside_balancer.go index 7351c46320..85343f9c80 100644 --- a/internal/proxy/look_aside_balancer.go +++ b/internal/proxy/look_aside_balancer.go @@ -102,7 +102,7 @@ func (b *LookAsideBalancer) SelectNode(ctx context.Context, availableNodes []int } score := b.calculateScore(cost, executingNQ.Load()) - metrics.ProxyWorkLoadScore.WithLabelValues(strconv.FormatInt(paramtable.GetNodeID(), 10)).Observe(score) + metrics.ProxyWorkLoadScore.WithLabelValues(strconv.FormatInt(node, 10)).Set(score) if targetNode == -1 || score < targetScore { targetScore = score diff --git a/pkg/metrics/proxy_metrics.go b/pkg/metrics/proxy_metrics.go index e7e34ca0e6..538329c6c2 100644 --- a/pkg/metrics/proxy_metrics.go +++ b/pkg/metrics/proxy_metrics.go @@ -249,14 +249,15 @@ var ( }, []string{usernameLabelName}) // ProxyWorkLoadScore record the score that measured query node's workload. - ProxyWorkLoadScore = prometheus.NewHistogramVec( - prometheus.HistogramOpts{ + ProxyWorkLoadScore = prometheus.NewGaugeVec( + prometheus.GaugeOpts{ Namespace: milvusNamespace, Subsystem: typeutil.ProxyRole, Name: "workload_score", Help: "score that measured query node's workload", - Buckets: buckets, - }, []string{nodeIDLabelName}) + }, []string{ + nodeIDLabelName, + }) ) // RegisterProxy registers Proxy metrics