admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-30 23:45:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix rocksdb_kv memory leak (#8743)

Browse Source 
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
This commit is contained in:
yukun 2021-09-28 19:36:04 +08:00 committed by GitHub
parent 54a4e2cbeb
commit 93fa86daf2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
internal/kv/rocksdb/rocksdb_kv.go
View File

@ -135,6 +135,7 @@ func (kv *RocksdbKV) MultiLoad(keys []string) ([]string, error) {
return []string{}, err
}
values = append(values, string(value.Data()))
value.Free()
}
return values, nil
}
@ -154,7 +155,7 @@ func (kv *RocksdbKV) MultiSave(kvs map[string]string) error {
return errors.New("Rocksdb instance is nil when do MultiSave")
}
writeBatch := gorocksdb.NewWriteBatch()
defer writeBatch.Clear()
defer writeBatch.Destroy()
for k, v := range kvs {
writeBatch.Put([]byte(k), []byte(v))
}
@ -207,7 +208,7 @@ func (kv *RocksdbKV) MultiRemove(keys []string) error {
return errors.New("Rocksdb instance is nil when do MultiRemove")
}
writeBatch := gorocksdb.NewWriteBatch()
defer writeBatch.Clear()
defer writeBatch.Destroy()
for _, key := range keys {
writeBatch.Delete([]byte(key))
}
@ -221,7 +222,7 @@ func (kv *RocksdbKV) MultiSaveAndRemove(saves map[string]string, removals []stri
return errors.New("Rocksdb instance is nil when do MultiSaveAndRemove")
}
writeBatch := gorocksdb.NewWriteBatch()
defer writeBatch.Clear()
defer writeBatch.Destroy()
for k, v := range saves {
writeBatch.Put([]byte(k), []byte(v))
}
@ -238,7 +239,7 @@ func (kv *RocksdbKV) DeleteRange(startKey, endKey string) error {
return errors.New("Rocksdb instance is nil when do DeleteRange")
}
writeBatch := gorocksdb.NewWriteBatch()
defer writeBatch.Clear()
defer writeBatch.Destroy()
if len(startKey) == 0 {
iter := kv.DB.NewIterator(kv.ReadOptions)
defer iter.Close()