admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-08 01:58:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Reduce task slot for standalone to 1/4 of normal datanode (#42808)

Browse Source 
issue: #42129

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
This commit is contained in:
cai.zhang 2025-06-20 16:38:46 +08:00 committed by GitHub
parent e15926b40c
commit 8f8ffe9989
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/datanode/index/util.go
View File

@ -98,7 +98,7 @@ func CalculateNodeSlots() int64 {
totalSlot := max(slot, 1) * paramtable.Get().DataNodeCfg.WorkerSlotUnit.GetAsInt64() * paramtable.Get().DataNodeCfg.BuildParallel.GetAsInt64() totalSlot := max(slot, 1) * paramtable.Get().DataNodeCfg.WorkerSlotUnit.GetAsInt64() * paramtable.Get().DataNodeCfg.BuildParallel.GetAsInt64()
if paramtable.GetRole() == typeutil.StandaloneRole { if paramtable.GetRole() == typeutil.StandaloneRole {
totalSlot = max(totalSlot/2, 1) totalSlot = max(int64(float64(totalSlot)*paramtable.Get().DataNodeCfg.StandaloneSlotRatio.GetAsFloat()), 1)
} }
return totalSlot return totalSlot
} }

11
pkg/util/paramtable/component_param.go
View File

@ -5191,7 +5191,8 @@ type dataNodeConfig struct {
// index services config // index services config
BuildParallel ParamItem `refreshable:"false"` BuildParallel ParamItem `refreshable:"false"`
WorkerSlotUnit ParamItem `refreshable:"true"` WorkerSlotUnit ParamItem `refreshable:"true"`
StandaloneSlotRatio ParamItem `refreshable:"false"`
} }
func (p *dataNodeConfig) init(base *BaseTable) { func (p *dataNodeConfig) init(base *BaseTable) {
@ -5618,6 +5619,14 @@ if this parameter <= 0, will set it as 10`,
Doc: "Indicates how many slots each worker occupies per 2c8g", Doc: "Indicates how many slots each worker occupies per 2c8g",
} }
p.WorkerSlotUnit.Init(base.mgr) p.WorkerSlotUnit.Init(base.mgr)
p.StandaloneSlotRatio = ParamItem{
Key: "dataNode.standaloneSlotFactor",
Version: "2.5.14",
DefaultValue: "0.25",
Doc: "Offline task slot ratio in standalone mode",
}
p.StandaloneSlotRatio.Init(base.mgr)
} }
type streamingConfig struct { type streamingConfig struct {

2
pkg/util/paramtable/component_param_test.go
View File

@ -625,6 +625,8 @@ func TestComponentParam(t *testing.T) {
assert.Equal(t, int64(2), Params.ClusteringCompactionWorkerPoolSize.GetAsInt64()) assert.Equal(t, int64(2), Params.ClusteringCompactionWorkerPoolSize.GetAsInt64())
assert.Equal(t, 2, Params.BloomFilterApplyParallelFactor.GetAsInt()) assert.Equal(t, 2, Params.BloomFilterApplyParallelFactor.GetAsInt())
assert.Equal(t, 16, Params.WorkerSlotUnit.GetAsInt())
assert.Equal(t, 0.25, Params.StandaloneSlotRatio.GetAsFloat())
}) })
t.Run("test streamingConfig", func(t *testing.T) { t.Run("test streamingConfig", func(t *testing.T) {