From 8d080383b7b2a85b33ff7c0c2a05172519c8b64d Mon Sep 17 00:00:00 2001 From: "yihao.dai" Date: Sat, 4 Nov 2023 00:58:21 +0800 Subject: [PATCH] Use merr to prevent datanode panic (#28121) Signed-off-by: bigsheeper --- internal/datanode/channel_meta.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/internal/datanode/channel_meta.go b/internal/datanode/channel_meta.go index 2b314aa80d..5890975562 100644 --- a/internal/datanode/channel_meta.go +++ b/internal/datanode/channel_meta.go @@ -18,7 +18,6 @@ package datanode import ( "context" - "fmt" "math" "path" "sync" @@ -201,7 +200,7 @@ func (c *ChannelMeta) getCollectionAndPartitionID(segID UniqueID) (collID, parti if seg, ok := c.segments[segID]; ok && seg.isValid() { return seg.collectionID, seg.partitionID, nil } - return 0, 0, fmt.Errorf("cannot find segment, id = %d", segID) + return 0, 0, merr.WrapErrSegmentNotFound(segID) } func (c *ChannelMeta) getChannelName() string { @@ -640,7 +639,7 @@ func (c *ChannelMeta) getSegmentStatisticsUpdates(segID UniqueID) (*commonpb.Seg return &commonpb.SegmentStats{SegmentID: segID, NumRows: seg.numRows}, nil } - return nil, fmt.Errorf("error, there's no segment %d", segID) + return nil, merr.WrapErrSegmentNotFound(segID) } func (c *ChannelMeta) getCollectionID() UniqueID {