From 8a6de3d2b1ba374fed2843d6a870daae307cb123 Mon Sep 17 00:00:00 2001 From: congqixia Date: Mon, 22 Jan 2024 14:44:55 +0800 Subject: [PATCH] fix: decompress deltelog path for level zero compaction (#30164) Resolves: #30161 See also: #28873 --------- Signed-off-by: Congqi Xia --- internal/datanode/l0_compactor.go | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/internal/datanode/l0_compactor.go b/internal/datanode/l0_compactor.go index fc17026a55..1141eebc54 100644 --- a/internal/datanode/l0_compactor.go +++ b/internal/datanode/l0_compactor.go @@ -30,6 +30,7 @@ import ( iter "github.com/milvus-io/milvus/internal/datanode/iterators" "github.com/milvus-io/milvus/internal/datanode/metacache" "github.com/milvus-io/milvus/internal/datanode/syncmgr" + "github.com/milvus-io/milvus/internal/metastore/kv/binlog" "github.com/milvus-io/milvus/internal/proto/datapb" "github.com/milvus-io/milvus/internal/storage" "github.com/milvus-io/milvus/pkg/common" @@ -132,6 +133,11 @@ func (t *levelZeroCompactionTask) compact() (*datapb.CompactionPlanResult, error log.Warn("compact wrong, not target sealed segments") return nil, errIllegalCompactionPlan } + err := binlog.DecompressCompactionBinlogs(l0Segments) + if err != nil { + log.Warn("DecompressCompactionBinlogs failed", zap.Error(err)) + return nil, err + } var ( totalSize int64 @@ -210,10 +216,7 @@ func (t *levelZeroCompactionTask) compact() (*datapb.CompactionPlanResult, error return lo.Values(resultSegments), nil } - var ( - resultSegments []*datapb.CompactionSegment - err error - ) + var resultSegments []*datapb.CompactionSegment // if totalSize*3 < int64(hardware.GetFreeMemoryCount()) { // resultSegments, err = batchProcess() // }