From 9f75c8d2aad36f930f3252c698f5ffbade597d87 Mon Sep 17 00:00:00 2001 From: groot Date: Wed, 29 May 2019 18:51:21 +0800 Subject: [PATCH 1/2] use faiss 1.5.2 Former-commit-id: 3005f905b39d72ef0018151d7e704023657083c6 --- cpp/src/server/MegasearchTask.cpp | 1 - cpp/thirdparty/versions.txt | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/cpp/src/server/MegasearchTask.cpp b/cpp/src/server/MegasearchTask.cpp index a1df83bcb3..6871893348 100644 --- a/cpp/src/server/MegasearchTask.cpp +++ b/cpp/src/server/MegasearchTask.cpp @@ -237,7 +237,6 @@ AddVectorTask::AddVectorTask(const std::string& table_name, record_array_(record_array), record_ids_(record_ids) { record_ids_.clear(); - record_ids_.resize(record_array.size()); } BaseTaskPtr AddVectorTask::Create(const std::string& table_name, diff --git a/cpp/thirdparty/versions.txt b/cpp/thirdparty/versions.txt index 772c709016..98e5381a56 100644 --- a/cpp/thirdparty/versions.txt +++ b/cpp/thirdparty/versions.txt @@ -26,7 +26,7 @@ BOOST_VERSION=1.70.0 BZIP2_VERSION=1.0.6 EASYLOGGINGPP_VERSION=v9.96.7 -FAISS_VERSION=master +FAISS_VERSION=v1.5.2 GTEST_VERSION=1.8.1 LAPACK_VERSION=v3.8.0 LZ4_VERSION=v1.9.1 From e509d29df38b58a0bb6e49aba91ef1a15ea96c23 Mon Sep 17 00:00:00 2001 From: groot Date: Wed, 29 May 2019 18:52:55 +0800 Subject: [PATCH 2/2] use faiss 1.5.2 Former-commit-id: cae61443fe5fb47752e94b19f03a32f3b80ad2f1 --- cpp/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/cpp/CHANGELOG.md b/cpp/CHANGELOG.md index 595bd8b4ec..94972363fa 100644 --- a/cpp/CHANGELOG.md +++ b/cpp/CHANGELOG.md @@ -21,3 +21,4 @@ Please mark all change in change log and use the ticket from JIRA. - MS-1 - Add CHANGELOG.md - MS-4 - Refactor the vecwise_engine code structure - MS-20 - Clean Code Part 1 +- MS-30 - Use faiss v1.5.2