From 87b466fd83e5cb07c66501c2aab2d389ec05dab5 Mon Sep 17 00:00:00 2001 From: Chun Han <116052805+MrPresent-Han@users.noreply.github.com> Date: Sat, 8 Nov 2025 10:29:33 +0800 Subject: [PATCH] fix: Group value is nil(#45418) (#45422) related: #45418 Signed-off-by: MrPresent-Han Co-authored-by: MrPresent-Han --- internal/proxy/search_reduce_util.go | 1 + internal/util/function/rerank/util.go | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/internal/proxy/search_reduce_util.go b/internal/proxy/search_reduce_util.go index b7695438c1..beeabb8ccd 100644 --- a/internal/proxy/search_reduce_util.go +++ b/internal/proxy/search_reduce_util.go @@ -514,6 +514,7 @@ func reduceResults(ctx context.Context, toReduceResults []*internalpb.SearchResu } if len(validSearchResults) <= 0 { + log.Debug("reduced search results is empty, fill in empty result") return fillInEmptyResult(nq), nil } diff --git a/internal/util/function/rerank/util.go b/internal/util/function/rerank/util.go index 7f552c9133..e388d0f3e5 100644 --- a/internal/util/function/rerank/util.go +++ b/internal/util/function/rerank/util.go @@ -25,6 +25,7 @@ import ( "strings" "github.com/milvus-io/milvus-proto/go-api/v2/schemapb" + "github.com/milvus-io/milvus/pkg/v2/log" "github.com/milvus-io/milvus/pkg/v2/util/merr" "github.com/milvus-io/milvus/pkg/v2/util/metric" "github.com/milvus-io/milvus/pkg/v2/util/typeutil" @@ -516,7 +517,8 @@ func genIdGroupingMap(multipSearchResultData []*schemapb.SearchResultData) (map[ idGroupValue := map[any]any{} for _, result := range multipSearchResultData { if result.GetGroupByFieldValue() == nil { - return nil, fmt.Errorf("Group value is nil") + log.Warn("Group value is nil, this is due to empty results in search reduce phase") + continue } size := typeutil.GetSizeOfIDs(result.Ids) groupIter := typeutil.GetDataIterator(result.GetGroupByFieldValue())