Merge pull request #463 from tinkerlin/issue-458

move seal to Load

CHANGELOG.md

@@ -18,6 +18,7 @@ Please mark all change in change log and use the ticket from JIRA.
 - \#412 - Message returned is confused when partition created with null partition name
 - \#416 - Drop the same partition success repeatally
 - \#440 - Query API in customization still uses old version
+- \#458 - Index data is not compatible between 0.5 and 0.6
 
 ## Feature
 - \#12 - Pure CPU version for Milvus

core/src/index/knowhere/knowhere/index/vector_index/FaissBaseIndex.cpp

@@ -33,7 +33,7 @@ FaissBaseIndex::SerializeImpl() {
     try {
         faiss::Index* index = index_.get();
 
-        SealImpl();
+        // SealImpl();
 
         MemoryIOWriter writer;
         faiss::write_index(index, &writer);
@@ -60,6 +60,8 @@ FaissBaseIndex::LoadImpl(const BinarySet& index_binary) {
     faiss::Index* index = faiss::read_index(&reader);
 
     index_.reset(index);
+
+    SealImpl();
 }
 
 void

core/src/index/knowhere/knowhere/index/vector_index/IndexGPUIVF.cpp

@@ -86,9 +86,6 @@ GPUIVF::SerializeImpl() {
             faiss::Index* index = index_.get();
             faiss::Index* host_index = faiss::gpu::index_gpu_to_cpu(index);
 
-            // TODO(linxj): support seal
-            // SealImpl();
-
             faiss::write_index(host_index, &writer);
             delete host_index;
         }

core/src/index/knowhere/knowhere/index/vector_index/IndexIVF.cpp

@@ -97,7 +97,6 @@ IVF::Serialize() {
     }
 
     std::lock_guard<std::mutex> lk(mutex_);
-    Seal();
     return SerializeImpl();
 }