admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-08 10:08:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

Refine log of CreateIndex (#13031)

Browse Source 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
This commit is contained in:
dragondriver 2021-12-10 16:48:50 +08:00 committed by GitHub
parent 6571f811c8
commit 86d69ef48c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 60 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
internal/proxy/impl.go
View File

@ -966,7 +966,7 @@ func (node *Proxy) HasPartition(ctx context.Context, request *milvuspb.HasPartit
}, nil }, nil
} }
sp, ctx := trace.StartSpanFromContextWithOperationName(ctx, "Proxy-Insert") sp, ctx := trace.StartSpanFromContextWithOperationName(ctx, "Proxy-HasPartition")
defer sp.Finish() defer sp.Finish()
traceID, _, _ := trace.InfoFromSpan(sp) traceID, _, _ := trace.InfoFromSpan(sp)
@ -1060,7 +1060,7 @@ func (node *Proxy) LoadPartitions(ctx context.Context, request *milvuspb.LoadPar
return unhealthyStatus(), nil return unhealthyStatus(), nil
} }
sp, ctx := trace.StartSpanFromContextWithOperationName(ctx, "Proxy-Insert") sp, ctx := trace.StartSpanFromContextWithOperationName(ctx, "Proxy-LoadPartitions")
defer sp.Finish() defer sp.Finish()
traceID, _, _ := trace.InfoFromSpan(sp) traceID, _, _ := trace.InfoFromSpan(sp)
@ -1417,6 +1417,11 @@ func (node *Proxy) CreateIndex(ctx context.Context, request *milvuspb.CreateInde
if !node.checkHealthy() { if !node.checkHealthy() {
return unhealthyStatus(), nil return unhealthyStatus(), nil
} }
sp, ctx := trace.StartSpanFromContextWithOperationName(ctx, "Proxy-ShowPartitions")
defer sp.Finish()
traceID, _, _ := trace.InfoFromSpan(sp)
cit := &createIndexTask{ cit := &createIndexTask{
ctx: ctx, ctx: ctx,
Condition: NewTaskCondition(ctx), Condition: NewTaskCondition(ctx),
@ -1424,48 +1429,78 @@ func (node *Proxy) CreateIndex(ctx context.Context, request *milvuspb.CreateInde
rootCoord: node.rootCoord, rootCoord: node.rootCoord,
} }
log.Debug("CreateIndex enqueue", method := "CreateIndex"
zap.String("role", Params.RoleName),
zap.String("db", request.DbName),
zap.String("collection", request.CollectionName),
zap.String("field", request.FieldName),
zap.Any("extra_params", request.ExtraParams))
err := node.sched.ddQueue.Enqueue(cit)
if err != nil {
return &commonpb.Status{
ErrorCode: commonpb.ErrorCode_UnexpectedError,
Reason: err.Error(),
}, nil
}
log.Debug("CreateIndex", log.Debug(
rpcReceived(method),
zap.String("traceID", traceID),
zap.String("role", Params.RoleName), zap.String("role", Params.RoleName),
zap.Int64("msgID", request.Base.MsgID),
zap.Uint64("timestamp", request.Base.Timestamp),
zap.String("db", request.DbName), zap.String("db", request.DbName),
zap.String("collection", request.CollectionName), zap.String("collection", request.CollectionName),
zap.String("field", request.FieldName), zap.String("field", request.FieldName),
zap.Any("extra_params", request.ExtraParams)) zap.Any("extra_params", request.ExtraParams))
defer func() {
log.Debug("CreateIndex Done", if err := node.sched.ddQueue.Enqueue(cit); err != nil {
log.Warn(
rpcFailedToEnqueue(method),
zap.Error(err), zap.Error(err),
zap.String("traceID", traceID),
zap.String("role", Params.RoleName), zap.String("role", Params.RoleName),
zap.Int64("msgID", request.Base.MsgID),
zap.Uint64("timestamp", request.Base.Timestamp),
zap.String("db", request.DbName), zap.String("db", request.DbName),
zap.String("collection", request.CollectionName), zap.String("collection", request.CollectionName),
zap.String("field", request.FieldName), zap.String("field", request.FieldName),
zap.Any("extra_params", request.ExtraParams)) zap.Any("extra_params", request.ExtraParams))
}()
err = cit.WaitToFinish()
if err != nil {
return &commonpb.Status{ return &commonpb.Status{
ErrorCode: commonpb.ErrorCode_UnexpectedError, ErrorCode: commonpb.ErrorCode_UnexpectedError,
Reason: err.Error(), Reason: err.Error(),
}, nil }, nil
} }
log.Debug(
rpcEnqueued(method),
zap.String("traceID", traceID),
zap.String("role", Params.RoleName),
zap.Int64("MsgID", cit.ID()),
zap.Uint64("BeginTs", cit.BeginTs()),
zap.Uint64("EndTs", cit.EndTs()),
zap.String("db", request.DbName),
zap.String("collection", request.CollectionName),
zap.String("field", request.FieldName),
zap.Any("extra_params", request.ExtraParams))
if err := cit.WaitToFinish(); err != nil {
log.Warn(
rpcFailedToWaitToFinish(method),
zap.Error(err),
zap.String("traceID", traceID),
zap.String("role", Params.RoleName),
zap.Int64("MsgID", cit.ID()),
zap.Uint64("BeginTs", cit.BeginTs()),
zap.Uint64("EndTs", cit.EndTs()),
zap.String("db", request.DbName),
zap.String("collection", request.CollectionName),
zap.String("field", request.FieldName),
zap.Any("extra_params", request.ExtraParams))
return &commonpb.Status{
ErrorCode: commonpb.ErrorCode_UnexpectedError,
Reason: err.Error(),
}, nil
}
log.Debug(
rpcDone(method),
zap.String("traceID", traceID),
zap.String("role", Params.RoleName),
zap.Int64("MsgID", cit.ID()),
zap.Uint64("BeginTs", cit.BeginTs()),
zap.Uint64("EndTs", cit.EndTs()),
zap.String("db", request.DbName),
zap.String("collection", request.CollectionName),
zap.String("field", request.FieldName),
zap.Any("extra_params", request.ExtraParams))
return cit.result, nil return cit.result, nil
} }