admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Save update timestamp in catalog.AlterCollection API (#41468)

Browse Source 
Related to #41467

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2025-04-23 16:48:37 +08:00 committed by GitHub
parent 3d4889586d
commit 85ed200529
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/metastore/kv/rootcoord/kv_catalog.go
View File

@ -647,6 +647,7 @@ func (kc *Catalog) alterModifyCollection(ctx context.Context, oldColl *model.Col
oldCollClone.State = newColl.State
oldCollClone.Properties = newColl.Properties
oldCollClone.Fields = newColl.Fields
oldCollClone.UpdateTimestamp = newColl.UpdateTimestamp
oldKey := BuildCollectionKey(oldColl.DBID, oldColl.CollectionID)
newKey := BuildCollectionKey(newColl.DBID, oldColl.CollectionID)

4
internal/metastore/kv/rootcoord/kv_catalog_test.go
View File

@ -3,6 +3,7 @@ package rootcoord
import (
"context"
"fmt"
"math/rand"
"strings"
"sync"
"testing"
@ -1046,7 +1047,7 @@ func TestCatalog_AlterCollection(t *testing.T) {
ctx := context.Background()
var collectionID int64 = 1
oldC := &model.Collection{CollectionID: collectionID, State: pb.CollectionState_CollectionCreating}
newC := &model.Collection{CollectionID: collectionID, State: pb.CollectionState_CollectionCreated}
newC := &model.Collection{CollectionID: collectionID, State: pb.CollectionState_CollectionCreated, UpdateTimestamp: rand.Uint64()}
err := kc.AlterCollection(ctx, oldC, newC, metastore.MODIFY, 0)
assert.NoError(t, err)
key := BuildCollectionKey(0, collectionID)
@ -1057,6 +1058,7 @@ func TestCatalog_AlterCollection(t *testing.T) {
assert.NoError(t, err)
got := model.UnmarshalCollectionModel(&collPb)
assert.Equal(t, pb.CollectionState_CollectionCreated, got.State)
assert.Equal(t, newC.UpdateTimestamp, got.UpdateTimestamp)
})
t.Run("modify, tenant id changed", func(t *testing.T) {