From 80465a01b56f1e1dd66fcb40d12ba9eac4b6e98c Mon Sep 17 00:00:00 2001 From: congqixia Date: Wed, 17 Jan 2024 17:48:53 +0800 Subject: [PATCH] enhance: change some important request log level to Info (#30062) Some important request log level shall be at least Info level Signed-off-by: Congqi Xia --- internal/proxy/impl.go | 64 +++++++++++++++++++++--------------------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/internal/proxy/impl.go b/internal/proxy/impl.go index 9abcdac814..86aafba615 100644 --- a/internal/proxy/impl.go +++ b/internal/proxy/impl.go @@ -436,7 +436,7 @@ func (node *Proxy) DropCollection(ctx context.Context, request *milvuspb.DropCol zap.String("collection", request.CollectionName), ) - log.Debug("DropCollection received") + log.Info("DropCollection received") if err := node.sched.ddQueue.Enqueue(dct); err != nil { log.Warn("DropCollection failed to enqueue", @@ -462,7 +462,7 @@ func (node *Proxy) DropCollection(ctx context.Context, request *milvuspb.DropCol return merr.Status(err), nil } - log.Debug( + log.Info( "DropCollection done", zap.Uint64("BeginTs", dct.BeginTs()), zap.Uint64("EndTs", dct.EndTs()), @@ -1021,7 +1021,7 @@ func (node *Proxy) AlterCollection(ctx context.Context, request *milvuspb.AlterC zap.String("db", request.DbName), zap.String("collection", request.CollectionName)) - log.Debug( + log.Info( rpcReceived(method)) if err := node.sched.ddQueue.Enqueue(act); err != nil { @@ -1050,7 +1050,7 @@ func (node *Proxy) AlterCollection(ctx context.Context, request *milvuspb.AlterC return merr.Status(err), nil } - log.Debug( + log.Info( rpcDone(method), zap.Uint64("BeginTs", act.BeginTs()), zap.Uint64("EndTs", act.EndTs())) @@ -1086,7 +1086,7 @@ func (node *Proxy) CreatePartition(ctx context.Context, request *milvuspb.Create zap.String("collection", request.CollectionName), zap.String("partition", request.PartitionName)) - log.Debug(rpcReceived(method)) + log.Info(rpcReceived(method)) if err := node.sched.ddQueue.Enqueue(cpt); err != nil { log.Warn( @@ -1115,7 +1115,7 @@ func (node *Proxy) CreatePartition(ctx context.Context, request *milvuspb.Create return merr.Status(err), nil } - log.Debug( + log.Info( rpcDone(method), zap.Uint64("BeginTS", cpt.BeginTs()), zap.Uint64("EndTS", cpt.EndTs())) @@ -1152,7 +1152,7 @@ func (node *Proxy) DropPartition(ctx context.Context, request *milvuspb.DropPart zap.String("collection", request.CollectionName), zap.String("partition", request.PartitionName)) - log.Debug(rpcReceived(method)) + log.Info(rpcReceived(method)) if err := node.sched.ddQueue.Enqueue(dpt); err != nil { log.Warn( @@ -1164,7 +1164,7 @@ func (node *Proxy) DropPartition(ctx context.Context, request *milvuspb.DropPart return merr.Status(err), nil } - log.Debug( + log.Info( rpcEnqueued(method), zap.Uint64("BeginTS", dpt.BeginTs()), zap.Uint64("EndTS", dpt.EndTs())) @@ -1181,7 +1181,7 @@ func (node *Proxy) DropPartition(ctx context.Context, request *milvuspb.DropPart return merr.Status(err), nil } - log.Debug( + log.Info( rpcDone(method), zap.Uint64("BeginTS", dpt.BeginTs()), zap.Uint64("EndTS", dpt.EndTs())) @@ -2062,7 +2062,7 @@ func (node *Proxy) DropIndex(ctx context.Context, request *milvuspb.DropIndexReq zap.String("field", request.FieldName), zap.String("index name", request.IndexName)) - log.Debug(rpcReceived(method)) + log.Info(rpcReceived(method)) if err := node.sched.ddQueue.Enqueue(dit); err != nil { log.Warn( @@ -2092,7 +2092,7 @@ func (node *Proxy) DropIndex(ctx context.Context, request *milvuspb.DropIndexReq return merr.Status(err), nil } - log.Debug( + log.Info( rpcDone(method), zap.Uint64("BeginTs", dit.BeginTs()), zap.Uint64("EndTs", dit.EndTs())) @@ -3156,7 +3156,7 @@ func (node *Proxy) CreateAlias(ctx context.Context, request *milvuspb.CreateAlia zap.String("alias", request.Alias), zap.String("collection", request.CollectionName)) - log.Debug(rpcReceived(method)) + log.Info(rpcReceived(method)) if err := node.sched.ddQueue.Enqueue(cat); err != nil { log.Warn( @@ -3184,7 +3184,7 @@ func (node *Proxy) CreateAlias(ctx context.Context, request *milvuspb.CreateAlia return merr.Status(err), nil } - log.Debug( + log.Info( rpcDone(method), zap.Uint64("BeginTs", cat.BeginTs()), zap.Uint64("EndTs", cat.EndTs())) @@ -3346,7 +3346,7 @@ func (node *Proxy) DropAlias(ctx context.Context, request *milvuspb.DropAliasReq zap.String("db", request.DbName), zap.String("alias", request.Alias)) - log.Debug(rpcReceived(method)) + log.Info(rpcReceived(method)) if err := node.sched.ddQueue.Enqueue(dat); err != nil { log.Warn( @@ -3374,7 +3374,7 @@ func (node *Proxy) DropAlias(ctx context.Context, request *milvuspb.DropAliasReq return merr.Status(err), nil } - log.Debug( + log.Info( rpcDone(method), zap.Uint64("BeginTs", dat.BeginTs()), zap.Uint64("EndTs", dat.EndTs())) @@ -3410,7 +3410,7 @@ func (node *Proxy) AlterAlias(ctx context.Context, request *milvuspb.AlterAliasR zap.String("alias", request.Alias), zap.String("collection", request.CollectionName)) - log.Debug(rpcReceived(method)) + log.Info(rpcReceived(method)) if err := node.sched.ddQueue.Enqueue(aat); err != nil { log.Warn( @@ -3438,7 +3438,7 @@ func (node *Proxy) AlterAlias(ctx context.Context, request *milvuspb.AlterAliasR return merr.Status(err), nil } - log.Debug( + log.Info( rpcDone(method), zap.Uint64("BeginTs", aat.BeginTs()), zap.Uint64("EndTs", aat.EndTs())) @@ -4338,7 +4338,7 @@ func (node *Proxy) CreateCredential(ctx context.Context, req *milvuspb.CreateCre log := log.Ctx(ctx).With( zap.String("username", req.Username)) - log.Debug("CreateCredential", + log.Info("CreateCredential", zap.String("role", typeutil.ProxyRole)) if err := merr.CheckHealthy(node.GetStateCode()); err != nil { return merr.Status(err), nil @@ -4389,7 +4389,7 @@ func (node *Proxy) UpdateCredential(ctx context.Context, req *milvuspb.UpdateCre log := log.Ctx(ctx).With( zap.String("username", req.Username)) - log.Debug("UpdateCredential", + log.Info("UpdateCredential", zap.String("role", typeutil.ProxyRole)) if err := merr.CheckHealthy(node.GetStateCode()); err != nil { return merr.Status(err), nil @@ -4457,7 +4457,7 @@ func (node *Proxy) DeleteCredential(ctx context.Context, req *milvuspb.DeleteCre log := log.Ctx(ctx).With( zap.String("username", req.Username)) - log.Debug("DeleteCredential", + log.Info("DeleteCredential", zap.String("role", typeutil.ProxyRole)) if err := merr.CheckHealthy(node.GetStateCode()); err != nil { return merr.Status(err), nil @@ -4510,7 +4510,7 @@ func (node *Proxy) CreateRole(ctx context.Context, req *milvuspb.CreateRoleReque log := log.Ctx(ctx) - log.Debug("CreateRole", zap.Any("req", req)) + log.Info("CreateRole", zap.Stringer("req", req)) if err := merr.CheckHealthy(node.GetStateCode()); err != nil { return merr.Status(err), nil } @@ -4537,7 +4537,7 @@ func (node *Proxy) DropRole(ctx context.Context, req *milvuspb.DropRoleRequest) log := log.Ctx(ctx) - log.Debug("DropRole", + log.Info("DropRole", zap.Any("req", req)) if err := merr.CheckHealthy(node.GetStateCode()); err != nil { return merr.Status(err), nil @@ -4565,7 +4565,7 @@ func (node *Proxy) OperateUserRole(ctx context.Context, req *milvuspb.OperateUse log := log.Ctx(ctx) - log.Debug("OperateUserRole", zap.Any("req", req)) + log.Info("OperateUserRole", zap.Any("req", req)) if err := merr.CheckHealthy(node.GetStateCode()); err != nil { return merr.Status(err), nil } @@ -4681,7 +4681,7 @@ func (node *Proxy) OperatePrivilege(ctx context.Context, req *milvuspb.OperatePr log := log.Ctx(ctx) - log.Debug("OperatePrivilege", + log.Info("OperatePrivilege", zap.Any("req", req)) if err := merr.CheckHealthy(node.GetStateCode()); err != nil { return merr.Status(err), nil @@ -4935,7 +4935,7 @@ func (node *Proxy) CreateResourceGroup(ctx context.Context, request *milvuspb.Cr zap.String("role", typeutil.ProxyRole), ) - log.Debug("CreateResourceGroup received") + log.Info("CreateResourceGroup received") if err := node.sched.ddQueue.Enqueue(t); err != nil { log.Warn("CreateResourceGroup failed to enqueue", @@ -4955,7 +4955,7 @@ func (node *Proxy) CreateResourceGroup(ctx context.Context, request *milvuspb.Cr return getErrResponse(err, method), nil } - log.Debug("CreateResourceGroup done", + log.Info("CreateResourceGroup done", zap.Uint64("BeginTS", t.BeginTs()), zap.Uint64("EndTS", t.EndTs())) @@ -4993,7 +4993,7 @@ func (node *Proxy) DropResourceGroup(ctx context.Context, request *milvuspb.Drop zap.String("role", typeutil.ProxyRole), ) - log.Debug("DropResourceGroup received") + log.Info("DropResourceGroup received") if err := node.sched.ddQueue.Enqueue(t); err != nil { log.Warn("DropResourceGroup failed to enqueue", @@ -5014,7 +5014,7 @@ func (node *Proxy) DropResourceGroup(ctx context.Context, request *milvuspb.Drop return getErrResponse(err, method), nil } - log.Debug("DropResourceGroup done", + log.Info("DropResourceGroup done", zap.Uint64("BeginTS", t.BeginTs()), zap.Uint64("EndTS", t.EndTs())) @@ -5060,7 +5060,7 @@ func (node *Proxy) TransferNode(ctx context.Context, request *milvuspb.TransferN zap.String("role", typeutil.ProxyRole), ) - log.Debug("TransferNode received") + log.Info("TransferNode received") if err := node.sched.ddQueue.Enqueue(t); err != nil { log.Warn("TransferNode failed to enqueue", @@ -5081,7 +5081,7 @@ func (node *Proxy) TransferNode(ctx context.Context, request *milvuspb.TransferN return getErrResponse(err, method), nil } - log.Debug("TransferNode done", + log.Info("TransferNode done", zap.Uint64("BeginTS", t.BeginTs()), zap.Uint64("EndTS", t.EndTs())) @@ -5127,7 +5127,7 @@ func (node *Proxy) TransferReplica(ctx context.Context, request *milvuspb.Transf zap.String("role", typeutil.ProxyRole), ) - log.Debug("TransferReplica received") + log.Info("TransferReplica received") if err := node.sched.ddQueue.Enqueue(t); err != nil { log.Warn("TransferReplica failed to enqueue", @@ -5148,7 +5148,7 @@ func (node *Proxy) TransferReplica(ctx context.Context, request *milvuspb.Transf return getErrResponse(err, method), nil } - log.Debug("TransferReplica done", + log.Info("TransferReplica done", zap.Uint64("BeginTS", t.BeginTs()), zap.Uint64("EndTS", t.EndTs()))