admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-02-02 01:06:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

(db/snapshot): fix InActiveResourcesGCEvent bug (#3611)

Browse Source 
Signed-off-by: peng.xu <peng.xu@zilliz.com>
This commit is contained in:
XuPeng-SH 2020-09-07 09:45:10 +08:00 committed by GitHub
parent 10eae7100e
commit 7e51b1fa6d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
core/src/db/snapshot/InActiveResourcesGCEvent.h
View File

@ -65,17 +65,18 @@ class InActiveResourcesGCEvent : public GCEvent, public Operations {
ClearInActiveResources(StorePtr store) {
std::vector<typename ResourceT::Ptr> resources;
STATUS_CHECK(store->GetInActiveResources<ResourceT>(resources));
auto res_prefix = store->GetRootPath();
for (auto& res : resources) {
std::string res_path = GetResPath<ResourceT>(dir_root_, res);
std::string res_path = GetResPath<ResourceT>(res_prefix, res);
if (res_path.empty()) {
/* std::cout << "[GC] No remove action for " << res_->ToString() << std::endl; */
} else if (std::experimental::filesystem::is_directory(res_path)) {
auto ok = std::experimental::filesystem::remove_all(res_path);
/* std::cout << "[GC] Remove dir " << res_->ToString() << " " << res_path << " " << ok << std::endl; */
/* std::cout << "[GC] Remove dir " << res->ToString() << " " << res_path << " " << ok << std::endl; */
} else if (std::experimental::filesystem::is_regular_file(res_path)) {
auto ok = std::experimental::filesystem::remove(res_path);
/* std::cout << "[GC] Remove file " << res_->ToString() << " " << res_path << " " << ok << std::endl; */
/* std::cout << "[GC] Remove file " << res->ToString() << " " << res_path << " " << ok << std::endl; */
} else {
RemoveWithSuffix<ResourceT>(res, res_path, store->GetSuffixSet());
LOG_ENGINE_DEBUG_ << "[GC] Remove stale " << res_path << " for " << res->ToString();
@ -88,9 +89,6 @@ class InActiveResourcesGCEvent : public GCEvent, public Operations {
return Status::OK();
}
private:
std::string dir_root_;
};
} // namespace snapshot