From 7e2fa55440f6e6d9e5f3dccadbd49797bfac55ef Mon Sep 17 00:00:00 2001 From: congqixia Date: Wed, 6 Sep 2023 12:39:14 +0800 Subject: [PATCH] Fix misuse of waitgroup in metrics mutex ut (#26865) Signed-off-by: Congqi Xia --- pkg/util/lock/metrics_mutex_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/util/lock/metrics_mutex_test.go b/pkg/util/lock/metrics_mutex_test.go index 8db946c966..3f050b713a 100644 --- a/pkg/util/lock/metrics_mutex_test.go +++ b/pkg/util/lock/metrics_mutex_test.go @@ -23,15 +23,15 @@ func TestMetricsLockLock(t *testing.T) { testRWLock := lManager.applyRWLock(lName) wg := sync.WaitGroup{} testRWLock.Lock("main_thread") + wg.Add(1) go func() { - wg.Add(1) + defer wg.Done() before := time.Now() testRWLock.Lock("sub_thread") lkDuration := time.Since(before) assert.True(t, lkDuration >= lockDuration) testRWLock.UnLock("sub_threadXX") testRWLock.UnLock("sub_thread") - wg.Done() }() time.Sleep(lockDuration) testRWLock.UnLock("main_thread") @@ -52,14 +52,14 @@ func TestMetricsLockRLock(t *testing.T) { testRWLock := lManager.applyRWLock(lName) wg := sync.WaitGroup{} testRWLock.RLock("main_thread") + wg.Add(1) go func() { - wg.Add(1) + defer wg.Done() before := time.Now() testRWLock.Lock("sub_thread") lkDuration := time.Since(before) assert.True(t, lkDuration >= lockDuration) testRWLock.UnLock("sub_thread") - wg.Done() }() time.Sleep(lockDuration) assert.Equal(t, 1, len(testRWLock.acquireTimeMap))