admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

enhance: replace magic number with ParamItem for dist handler (#30020)

Browse Source 
See also #28817

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2024-01-16 17:33:03 +08:00 committed by GitHub
parent 2a0eb1d2e6
commit 7cb6bebd96
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
internal/querycoordv2/dist/dist_handler.go vendored
View File

@ -35,12 +35,7 @@ import (
"github.com/milvus-io/milvus/pkg/log"
"github.com/milvus-io/milvus/pkg/util/commonpbutil"
"github.com/milvus-io/milvus/pkg/util/merr"
)
const (
distReqTimeout = 3 * time.Second
heartBeatLagBehindWarn = 3 * time.Second
maxFailureTimes = 3
"github.com/milvus-io/milvus/pkg/util/paramtable"
)
type distHandler struct {
@ -96,7 +91,7 @@ func (dh *distHandler) handleDistResp(resp *querypb.GetDataDistributionResponse)
session.WithSegmentCnt(len(resp.GetSegments())),
session.WithChannelCnt(len(resp.GetChannels())),
)
if time.Since(node.LastHeartbeat()) > heartBeatLagBehindWarn {
if time.Since(node.LastHeartbeat()) > paramtable.Get().QueryCoordCfg.HeartBeatWarningLag.GetAsDuration(time.Millisecond) {
log.Warn("node last heart beat time lag too behind", zap.Time("now", time.Now()),
zap.Time("lastHeartBeatTime", node.LastHeartbeat()), zap.Int64("nodeID", node.ID()))
}
@ -226,7 +221,7 @@ func (dh *distHandler) getDistribution(ctx context.Context) (*querypb.GetDataDis
channels[channel.GetChannelName()] = targetChannel.GetSeekPosition()
}
ctx, cancel := context.WithTimeout(ctx, distReqTimeout)
ctx, cancel := context.WithTimeout(ctx, paramtable.Get().QueryCoordCfg.DistributionRequestTimeout.GetAsDuration(time.Millisecond))
defer cancel()
resp, err := dh.client.GetDataDistribution(ctx, dh.nodeID, &querypb.GetDataDistributionRequest{
Base: commonpbutil.NewMsgBase(

21
pkg/util/paramtable/component_param.go
View File

@ -1358,6 +1358,9 @@ type queryCoordConfig struct {
HeartbeatAvailableInterval ParamItem `refreshable:"true"`
LoadTimeoutSeconds ParamItem `refreshable:"true"`
DistributionRequestTimeout ParamItem `refreshable:"true"`
HeartBeatWarningLag ParamItem `refreshable:"true"`
// Deprecated: Since 2.2.2, QueryCoord do not use HandOff logic anymore
CheckHandoffInterval ParamItem `refreshable:"true"`
EnableActiveStandby ParamItem `refreshable:"false"`
@ -1738,6 +1741,24 @@ func (p *queryCoordConfig) init(base *BaseTable) {
Export: true,
}
p.CheckNodeSessionInterval.Init(base.mgr)
p.DistributionRequestTimeout = ParamItem{
Key: "queryCoord.distRequestTimeout",
Version: "2.3.6",
DefaultValue: "5000",
Doc: "the request timeout for querycoord fetching data distribution from querynodes, in milliseconds",
Export: true,
}
p.DistributionRequestTimeout.Init(base.mgr)
p.HeartBeatWarningLag = ParamItem{
Key: "queryCoord.heatbeatWarningLag",
Version: "2.3.6",
DefaultValue: "5000",
Doc: "the lag value for querycoord report warning when last heatbeat is too old, in milliseconds",
Export: true,
}
p.HeartBeatWarningLag.Init(base.mgr)
}
// /////////////////////////////////////////////////////////////////////////////