admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-06 17:18:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add retry logic for DataCoord GC minio bucket (#14095)

Browse Source 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This commit is contained in:
congqixia 2021-12-23 21:48:25 +08:00 committed by GitHub
parent 24e2faf110
commit 7c83b52de0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
internal/datacoord/server.go
View File

@ -340,15 +340,27 @@ func (s *Server) initGarbageCollection() error {
if err != nil {
return err
}
has, err := cli.BucketExists(context.TODO(), Params.DataCoordCfg.MinioBucketName)
if err != nil {
return err
}
if !has {
err = cli.MakeBucket(context.TODO(), Params.DataCoordCfg.MinioBucketName, minio.MakeBucketOptions{})
checkBucketFn := func() error {
has, err := cli.BucketExists(context.TODO(), Params.DataCoordCfg.MinioBucketName)
if err != nil {
return err
}
if !has {
err = cli.MakeBucket(context.TODO(), Params.DataCoordCfg.MinioBucketName, minio.MakeBucketOptions{})
if err != nil {
return err
}
}
return nil
}
// retry times shall be two, just to prevent
// 1. bucket not exists
// 2. bucket is created by other componnent
// 3. datacoord try to create but failed with bucket already exists error
err = retry.Do(s.ctx, checkBucketFn, retry.Attempts(2))
if err != nil {
return err
}
}