admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-28 22:45:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix rocksdb_kv error process (#8744)

Browse Source 
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
This commit is contained in:
yukun 2021-09-28 20:36:04 +08:00 committed by GitHub
parent 10bd4ee330
commit 7c2729916b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/kv/rocksdb/rocksdb_kv.go
View File

@ -74,8 +74,11 @@ func (kv *RocksdbKV) Load(key string) (string, error) {
}
value, err := kv.DB.Get(kv.ReadOptions, []byte(key))
if err != nil {
return "", err
}
defer value.Free()
return string(value.Data()), err
return string(value.Data()), nil
}
// LoadWithPrefix returns a batch values of keys with a prefix
@ -134,6 +137,7 @@ func (kv *RocksdbKV) MultiLoad(keys []string) ([]string, error) {
if err != nil {
return []string{}, err
}
defer value.Free()
values = append(values, string(value.Data()))
value.Free()
}

4
internal/kv/rocksdb/rocksdb_kv_test.go
View File

@ -174,4 +174,8 @@ func TestRocksdbKV_Dummy(t *testing.T) {
assert.Error(t, err)
err = rocksdbkv.DeleteRange("", "")
assert.Error(t, err)
rocksdbkv.ReadOptions = nil
_, err = rocksdbkv.Load("dummy")
assert.Error(t, err)
}