From 792e931fcb20149732370f5c6435ef45976a384f Mon Sep 17 00:00:00 2001 From: zhagnlu Date: Tue, 4 Nov 2025 20:21:36 +0800 Subject: [PATCH] enhance: rename jsonstats related user config params (#45254) #44132 Signed-off-by: luzhang Co-authored-by: luzhang --- configs/milvus.yaml | 18 +++++------ pkg/util/paramtable/component_param.go | 45 +++++++++++++++----------- 2 files changed, 36 insertions(+), 27 deletions(-) diff --git a/configs/milvus.yaml b/configs/milvus.yaml index 23ff722a22..a868c77908 100644 --- a/configs/milvus.yaml +++ b/configs/milvus.yaml @@ -511,7 +511,7 @@ queryNode: vectorIndex: false # Enable mmap for loading vector index scalarField: false # Enable mmap for loading scalar data scalarIndex: false # Enable mmap for loading scalar index - jsonStats: true # Enable mmap for loading json stats + jsonShredding: true # Enable mmap for loading json stats # Enable memory mapping (mmap) to optimize the handling of growing raw data. # By activating this feature, the memory overhead associated with newly added or modified data will be significantly minimized. # However, this optimization may come at the cost of a slight decrease in query latency for the affected data segments. @@ -729,11 +729,11 @@ dataCoord: indexTaskSlotUsage: 64 # slot usage of index task per 512mb statsTaskSlotUsage: 8 # slot usage of stats task per 512mb analyzeTaskSlotUsage: 65535 # slot usage of analyze task - jsonStatsTriggerCount: 10 # jsonkey stats task count per trigger - jsonStatsTriggerInterval: 10 # jsonkey task interval per trigger - jsonStatsMaxShreddingColumns: 1024 # the max number of columns to shred - jsonStatsShreddingRatioThreshold: 0.3 # the ratio threshold to shred - jsonStatsWriteBatchSize: 819200 # the batch size to write + jsonShreddingTriggerCount: 10 # jsonkey stats task count per trigger + jsonShreddingTriggerInterval: 10 # jsonkey task interval per trigger + jsonShreddingMaxColumns: 1024 # the max number of columns to shred + jsonShreddingRatioThreshold: 0.3 # the ratio threshold to shred + jsonShreddingWriteBatchSize: 81920 # the batch size to write ip: # TCP/IP address of dataCoord. If not specified, use the first unicastable address port: 13333 # TCP port of dataCoord grpc: @@ -1023,11 +1023,11 @@ common: sync: taskPoolReleaseTimeoutSeconds: 60 # The maximum time to wait for the task to finish and release resources in the pool enabledOptimizeExpr: true # Indicates whether to enable optimize expr - enabledJSONKeyStats: true # Indicates sealedsegment whether to enable JSON key stats - enabledGrowingSegmentJSONKeyStats: false # Indicates growingsegment whether to enable JSON key stats + enabledJSONShredding: true # Indicates sealedsegment whether to enable JSON key stats + enabledGrowingSegmentJSONShredding: false # Indicates growingsegment whether to enable JSON key stats enableConfigParamTypeCheck: true # Indicates whether to enable config param type check enablePosixMode: false # Specifies whether to run in POSIX mode for enhanced file system compatibility - UsingJSONStatsForQuery: true # Indicates whether to use json stats when query + usingJSONShreddingForQuery: true # Indicates whether to use json stats when query clusterID: 0 # cluster id # QuotaConfig, configurations of Milvus quota and limits. diff --git a/pkg/util/paramtable/component_param.go b/pkg/util/paramtable/component_param.go index 2cdd639d8b..88683adb6b 100644 --- a/pkg/util/paramtable/component_param.go +++ b/pkg/util/paramtable/component_param.go @@ -1209,28 +1209,31 @@ This helps Milvus-CDC synchronize incremental data`, p.EnabledOptimizeExpr.Init(base.mgr) p.UsingJSONStatsForQuery = ParamItem{ - Key: "common.UsingJSONStatsForQuery", - Version: "2.5.6", + Key: "common.usingJSONShreddingForQuery", + Version: "2.6.5", DefaultValue: "true", Doc: "Indicates whether to use json stats when query", + FallbackKeys: []string{"common.UsingJSONStatsForQuery"}, Export: true, } p.UsingJSONStatsForQuery.Init(base.mgr) p.EnabledJSONKeyStats = ParamItem{ - Key: "common.enabledJSONKeyStats", - Version: "2.5.5", + Key: "common.enabledJSONShredding", + Version: "2.6.5", DefaultValue: "true", Doc: "Indicates sealedsegment whether to enable JSON key stats", + FallbackKeys: []string{"common.enabledJSONKeyStats"}, Export: true, } p.EnabledJSONKeyStats.Init(base.mgr) p.EnabledGrowingSegmentJSONKeyStats = ParamItem{ - Key: "common.enabledGrowingSegmentJSONKeyStats", - Version: "2.5.5", + Key: "common.enabledGrowingSegmentJSONShredding", + Version: "2.6.5", DefaultValue: "false", Doc: "Indicates growingsegment whether to enable JSON key stats", + FallbackKeys: []string{"common.enabledGrowingSegmentJSONKeyStats"}, Export: true, } p.EnabledGrowingSegmentJSONKeyStats.Init(base.mgr) @@ -3817,10 +3820,11 @@ This defaults to true, indicating that Milvus creates temporary index for growin p.MmapScalarIndex.Init(base.mgr) p.MmapJSONStats = ParamItem{ - Key: "queryNode.mmap.jsonStats", - Version: "2.6.1", + Key: "queryNode.mmap.jsonShredding", + Version: "2.6.5", DefaultValue: "true", Doc: "Enable mmap for loading json stats", + FallbackKeys: []string{"queryNode.mmap.jsonStats"}, Export: true, } p.MmapJSONStats.Init(base.mgr) @@ -5553,20 +5557,22 @@ if param targetVecIndexVersion is not set, the default value is -1, which means p.SortCompactionTriggerCount.Init(base.mgr) p.JSONStatsTriggerCount = ParamItem{ - Key: "dataCoord.jsonStatsTriggerCount", - Version: "2.5.5", + Key: "dataCoord.jsonShreddingTriggerCount", + Version: "2.6.5", Doc: "jsonkey stats task count per trigger", DefaultValue: "10", + FallbackKeys: []string{"dataCoord.jsonStatsTriggerCount"}, PanicIfEmpty: false, Export: true, } p.JSONStatsTriggerCount.Init(base.mgr) p.JSONStatsTriggerInterval = ParamItem{ - Key: "dataCoord.jsonStatsTriggerInterval", - Version: "2.5.5", + Key: "dataCoord.jsonShreddingTriggerInterval", + Version: "2.6.5", Doc: "jsonkey task interval per trigger", DefaultValue: "10", + FallbackKeys: []string{"dataCoord.jsonStatsTriggerInterval"}, PanicIfEmpty: false, Export: true, } @@ -5583,11 +5589,12 @@ if param targetVecIndexVersion is not set, the default value is -1, which means p.RequestTimeoutSeconds.Init(base.mgr) p.JSONStatsMaxShreddingColumns = ParamItem{ - Key: "dataCoord.jsonStatsMaxShreddingColumns", - Version: "2.6.1", + Key: "dataCoord.jsonShreddingMaxColumns", + Version: "2.6.5", DefaultValue: "1024", Doc: "the max number of columns to shred", Export: true, + FallbackKeys: []string{"dataCoord.jsonStatsMaxShreddingColumns"}, Formatter: func(value string) string { v := getAsInt(value) if v > 10000 { @@ -5599,19 +5606,21 @@ if param targetVecIndexVersion is not set, the default value is -1, which means p.JSONStatsMaxShreddingColumns.Init(base.mgr) p.JSONStatsShreddingRatioThreshold = ParamItem{ - Key: "dataCoord.jsonStatsShreddingRatioThreshold", - Version: "2.6.1", + Key: "dataCoord.jsonShreddingRatioThreshold", + Version: "2.6.5", DefaultValue: "0.3", Doc: "the ratio threshold to shred", + FallbackKeys: []string{"dataCoord.jsonStatsShreddingRatioThreshold"}, Export: true, } p.JSONStatsShreddingRatioThreshold.Init(base.mgr) p.JSONStatsWriteBatchSize = ParamItem{ - Key: "dataCoord.jsonStatsWriteBatchSize", - Version: "2.6.1", + Key: "dataCoord.jsonShreddingWriteBatchSize", + Version: "2.6.5", DefaultValue: "81920", Doc: "the batch size to write", + FallbackKeys: []string{"dataCoord.jsonStatsWriteBatchSize"}, Export: true, } p.JSONStatsWriteBatchSize.Init(base.mgr)