admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2025-12-07 01:28:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: dirty cp metrics after drop (#43567)

Browse Source 
issue: #42688

- The channel cp is dropped by garbage collector
- The channel is dropped and the cp is marked as math.Uint64
- If we drop it here, the update channel checkpoints will write the
dirty cp back.

Signed-off-by: chyezh <chyezh@outlook.com>
This commit is contained in:
Zhen Ye 2025-07-27 23:22:55 +08:00 committed by GitHub
parent feb5db60f2
commit 7877aaa96c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/datacoord/handler.go
View File

@ -593,11 +593,6 @@ func (h *ServerHandler) FinishDropChannel(channel string, collectionID int64) er
log.Warn("DropChannel failed", zap.String("vChannel", channel), zap.Error(err)) log.Warn("DropChannel failed", zap.String("vChannel", channel), zap.Error(err))
return err return err
} }
err = h.s.meta.DropChannelCheckpoint(channel)
if err != nil {
log.Warn("DropChannel failed to drop channel checkpoint", zap.String("channel", channel), zap.Error(err))
return err
}
log.Info("DropChannel succeeded", zap.String("channel", channel)) log.Info("DropChannel succeeded", zap.String("channel", channel))
// Channel checkpoints are cleaned up during garbage collection. // Channel checkpoints are cleaned up during garbage collection.