From 70ec00cd5db43170ac59b0a67e7e8c021b341082 Mon Sep 17 00:00:00 2001
From: aoiasd <45024769+aoiasd@users.noreply.github.com>
Date: Fri, 5 Jan 2024 16:34:47 +0800
Subject: [PATCH] enhance: support access log print cluster prefix (#29646)

relate: https://github.com/milvus-io/milvus/issues/29645

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
---
 internal/proxy/accesslog/formatter.go | 1 +
 internal/proxy/accesslog/info.go      | 5 +++++
 internal/proxy/accesslog/info_test.go | 9 +++++++++
 3 files changed, 15 insertions(+)

diff --git a/internal/proxy/accesslog/formatter.go b/internal/proxy/accesslog/formatter.go
index fae0ea4278..eacdc283d1 100644
--- a/internal/proxy/accesslog/formatter.go
+++ b/internal/proxy/accesslog/formatter.go
@@ -49,6 +49,7 @@ var metricFuncMap = map[string]getMetricFunc{
 	"$time_end":        getTimeEnd,
 	"$method_expr":     getExpr,
 	"$sdk_version":     getSdkVersion,
+	"$cluster_prefix":  getClusterPrefix,
 }
 
 var BaseFormatterKey = "base"
diff --git a/internal/proxy/accesslog/info.go b/internal/proxy/accesslog/info.go
index 68ed4eed26..85e0e4f88d 100644
--- a/internal/proxy/accesslog/info.go
+++ b/internal/proxy/accesslog/info.go
@@ -32,6 +32,7 @@ import (
 	"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
 	"github.com/milvus-io/milvus/internal/proxy/connection"
 	"github.com/milvus-io/milvus/pkg/util/merr"
+	"github.com/milvus-io/milvus/pkg/util/paramtable"
 	"github.com/milvus-io/milvus/pkg/util/requestutil"
 )
 
@@ -272,3 +273,7 @@ func getSdkVersion(i *GrpcAccessInfo) string {
 	}
 	return clientInfo.SdkType + "-" + clientInfo.SdkVersion
 }
+
+func getClusterPrefix(i *GrpcAccessInfo) string {
+	return paramtable.Get().CommonCfg.ClusterPrefix.GetValue()
+}
diff --git a/internal/proxy/accesslog/info_test.go b/internal/proxy/accesslog/info_test.go
index 873b0fc5e8..d2c4215268 100644
--- a/internal/proxy/accesslog/info_test.go
+++ b/internal/proxy/accesslog/info_test.go
@@ -35,6 +35,7 @@ import (
 	"github.com/milvus-io/milvus/pkg/util"
 	"github.com/milvus-io/milvus/pkg/util/crypto"
 	"github.com/milvus-io/milvus/pkg/util/merr"
+	"github.com/milvus-io/milvus/pkg/util/paramtable"
 )
 
 type GrpcAccessInfoSuite struct {
@@ -148,6 +149,14 @@ func (s *GrpcAccessInfoSuite) TestExpression() {
 	s.Equal(testExpr, result[0])
 }
 
+func (s *GrpcAccessInfoSuite) TestClusterPrefix() {
+	cluster := "instance-test"
+	paramtable.Init()
+	paramtable.Get().Save(paramtable.Get().CommonCfg.ClusterPrefix.Key, cluster)
+	result := s.info.Get("$cluster_prefix")
+	s.Equal(cluster, result[0])
+}
+
 func TestGrpcAccssInfo(t *testing.T) {
 	suite.Run(t, new(GrpcAccessInfoSuite))
 }