From 6e2872c9821e930182070c0f7046e06d65901ead Mon Sep 17 00:00:00 2001 From: wgcn <1026688210@qq.com> Date: Wed, 10 Dec 2025 14:17:13 +0800 Subject: [PATCH] fix: wrong reduce lantency metric (#46233) #46248 Signed-off-by: wgcn Co-authored-by: wgcn --- internal/querynodev2/handlers.go | 6 ++++++ internal/querynodev2/services.go | 5 ----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/internal/querynodev2/handlers.go b/internal/querynodev2/handlers.go index 6707081573..61b2c91e5d 100644 --- a/internal/querynodev2/handlers.go +++ b/internal/querynodev2/handlers.go @@ -435,6 +435,12 @@ func (node *QueryNode) searchChannel(ctx context.Context, req *querypb.SearchReq reduce.NewReduceSearchResultInfo(req.GetReq().GetNq(), req.GetReq().GetTopk()).WithMetricType(req.GetReq().GetMetricType()).WithGroupByField(req.GetReq().GetGroupByFieldId()). WithGroupSize(req.GetReq().GetGroupSize()).WithAdvance(req.GetReq().GetIsAdvanced())) + + reduceLatency := tr.RecordSpan() + metrics.QueryNodeReduceLatency. + WithLabelValues(fmt.Sprint(node.GetNodeID()), metrics.SearchLabel, metrics.ReduceShards, metrics.BatchReduce). + Observe(float64(reduceLatency.Milliseconds())) + if err != nil { return nil, err } diff --git a/internal/querynodev2/services.go b/internal/querynodev2/services.go index 459fdf13d7..b48e7117c3 100644 --- a/internal/querynodev2/services.go +++ b/internal/querynodev2/services.go @@ -878,13 +878,8 @@ func (node *QueryNode) Search(ctx context.Context, req *querypb.SearchRequest) ( return resp, nil } - tr.RecordSpan() ret.Status = merr.Success() - reduceLatency := tr.RecordSpan() - metrics.QueryNodeReduceLatency. - WithLabelValues(fmt.Sprint(node.GetNodeID()), metrics.SearchLabel, metrics.ReduceShards, metrics.BatchReduce). - Observe(float64(reduceLatency.Milliseconds())) metrics.QueryNodeExecuteCounter.WithLabelValues(strconv.FormatInt(node.GetNodeID(), 10), metrics.SearchLabel). Add(float64(proto.Size(req)))