admin/milvus
1
0
Fork 0
mirror of https://gitee.com/milvus-io/milvus.git synced 2026-01-07 19:31:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

enhance: improve search by PK with duplicate check and auto anns_field inference (#46744)

Browse Source 
issue: #46740

  - Add duplicate ID check before query execution (fail fast)
  - Auto infer anns_field when only one vector field exists in schema

Signed-off-by: Li Liu <li.liu@zilliz.com>
This commit is contained in:
Li Liu 2026-01-05 14:07:23 +08:00 committed by GitHub
parent 7018151c7d
commit 69083617b6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
internal/proxy/impl.go
View File

@ -3431,6 +3431,16 @@ func (node *Proxy) handleIfSearchByPK(ctx context.Context, request *milvuspb.Sea
return nil // Not search by PK, do nothing
}
// Check for duplicate IDs (fail fast before query)
inputIDsCount := typeutil.GetSizeOfIDs(ids)
checker, err := typeutil.NewIDsChecker(ids)
if err != nil {
return err
}
if checker.Size() != inputIDsCount {
return merr.WrapErrParameterInvalidMsg("duplicate IDs found in search request")
}
// Get collection schema for validation and plan building
collectionInfo, err := globalMetaCache.GetCollectionInfo(ctx,
request.GetDbName(), request.GetCollectionName(), 0)
@ -3438,11 +3448,19 @@ func (node *Proxy) handleIfSearchByPK(ctx context.Context, request *milvuspb.Sea
return err
}
// Validate that anns_field is provided
// Get anns_field from search params, or infer from schema if only one vector field exists
annsFieldName, err := funcutil.GetAttrByKeyFromRepeatedKV(AnnsFieldKey, request.SearchParams)
if err != nil || annsFieldName == "" {
return merr.WrapErrParameterInvalid("valid anns_field in search_params", "missing",
"anns_field is required for search by IDs")
vecFields := typeutil.GetVectorFieldSchemas(collectionInfo.schema.CollectionSchema)
if len(vecFields) == 0 {
return merr.WrapErrParameterInvalid("valid anns_field in search_params", "missing",
"no vector field found in schema")
}
if enableMultipleVectorFields && len(vecFields) > 1 {
return merr.WrapErrParameterInvalid("valid anns_field in search_params", "missing",
"multiple vector fields exist, please specify anns_field in search_params")
}
annsFieldName = vecFields[0].Name
}
annField := typeutil.GetFieldByName(collectionInfo.schema.CollectionSchema, annsFieldName)
@ -3527,7 +3545,6 @@ func (node *Proxy) handleIfSearchByPK(ctx context.Context, request *milvuspb.Sea
}
// Check if the returned pk count matches the input IDs count
inputIDsCount := typeutil.GetSizeOfIDs(ids)
returnedPKCount := typeutil.GetPKSize(pkFieldData)
if returnedPKCount != inputIDsCount {
// Find which IDs are missing