From a931a0ea37db4a7c048599094e6e9c43044e43a1 Mon Sep 17 00:00:00 2001 From: starlord Date: Thu, 17 Oct 2019 17:28:37 +0800 Subject: [PATCH 1/2] fix clang-format failure Former-commit-id: f17e0b33eb6862ed8cbfabb1b2c7b57aaed2f96f --- core/build.sh | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/core/build.sh b/core/build.sh index 795c87c6bf..6697cfdfd2 100755 --- a/core/build.sh +++ b/core/build.sh @@ -91,6 +91,10 @@ fi cd ${BUILD_OUTPUT_DIR} +# remove make cache since build.sh -l use default variables +# force update the variables each time +make rebuild_cache + CMAKE_CMD="cmake \ -DBUILD_UNIT_TEST=${BUILD_UNITTEST} \ -DCMAKE_INSTALL_PREFIX=${INSTALL_PREFIX} @@ -115,7 +119,6 @@ if [[ ${RUN_CPPLINT} == "ON" ]]; then make lint if [ $? -ne 0 ]; then echo "ERROR! cpplint check failed" - rm -f CMakeCache.txt exit 1 fi echo "cpplint check passed!" @@ -124,7 +127,6 @@ if [[ ${RUN_CPPLINT} == "ON" ]]; then make check-clang-format if [ $? -ne 0 ]; then echo "ERROR! clang-format check failed" - rm -f CMakeCache.txt exit 1 fi echo "clang-format check passed!" @@ -133,12 +135,9 @@ if [[ ${RUN_CPPLINT} == "ON" ]]; then # make check-clang-tidy # if [ $? -ne 0 ]; then # echo "ERROR! clang-tidy check failed" -# rm -f CMakeCache.txt # exit 1 # fi # echo "clang-tidy check passed!" - - rm -f CMakeCache.txt else # compile and build make -j 4 || exit 1 From 5ef9620e2fa0408bbf250883fa3ace04f6be05f0 Mon Sep 17 00:00:00 2001 From: starlord Date: Thu, 17 Oct 2019 17:51:13 +0800 Subject: [PATCH 2/2] #31 make clang-format failed after run build.sh -l Former-commit-id: 03020a762b43c539ea09aca4cd5a6e96b9c8dc80 --- CHANGELOG.md | 1 + core/build.sh | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3905cb21d9..1119c8200e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,7 @@ Please mark all change in change log and use the ticket from JIRA. - MS-658 - Fix SQ8 Hybrid can't search - \#20 - C++ sdk example get grpc error - \#23 - Add unittest to improve code coverage +- \#31 - make clang-format failed after run build.sh -l ## Improvement - MS-552 - Add and change the easylogging library diff --git a/core/build.sh b/core/build.sh index 6697cfdfd2..cd6f65201b 100755 --- a/core/build.sh +++ b/core/build.sh @@ -92,7 +92,7 @@ fi cd ${BUILD_OUTPUT_DIR} # remove make cache since build.sh -l use default variables -# force update the variables each time +# force update the variables each time make rebuild_cache CMAKE_CMD="cmake \