From 3cbc8b6825ce0b88b4d01fc103077ce17f487736 Mon Sep 17 00:00:00 2001
From: starlord <chxiehust@gmail.com>
Date: Wed, 25 Sep 2019 10:50:33 +0800
Subject: [PATCH 1/2] MS-586 Remove BUILD_FAISS_WITH_MKL option

Former-commit-id: 22f4383828bc1e975c7b21e8ee6a64936039e41b
---
 cpp/CHANGELOG.md |  1 +
 cpp/build.sh     | 10 ++--------
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/cpp/CHANGELOG.md b/cpp/CHANGELOG.md
index 5fb91c72d2..23acfecf2b 100644
--- a/cpp/CHANGELOG.md
+++ b/cpp/CHANGELOG.md
@@ -29,6 +29,7 @@ Please mark all change in change log and use the ticket from JIRA.
 - MS-567 - Add NOTICE.md
 - MS-569 - Complete the NOTICE.md
 - MS-575 - Add Clang-format & Clang-tidy & Cpplint
+- MS-586 - Remove BUILD_FAISS_WITH_MKL option
 
 # Milvus 0.4.0 (2019-09-12)
 
diff --git a/cpp/build.sh b/cpp/build.sh
index b09e5b6313..013d4d575d 100755
--- a/cpp/build.sh
+++ b/cpp/build.sh
@@ -7,10 +7,9 @@ MAKE_CLEAN="OFF"
 BUILD_COVERAGE="OFF"
 DB_PATH="/opt/milvus"
 PROFILING="OFF"
-BUILD_FAISS_WITH_MKL="OFF"
 USE_JFROG_CACHE="OFF"
 
-while getopts "p:d:t:uhrcgmj" arg
+while getopts "p:d:t:uhrcgj" arg
 do
         case $arg in
              t)
@@ -38,9 +37,6 @@ do
              g)
                 PROFILING="ON"
                 ;;
-             m)
-                BUILD_FAISS_WITH_MKL="ON"
-                ;;
              j)
                 USE_JFROG_CACHE="ON"
                 ;;
@@ -55,11 +51,10 @@ parameter:
 -r: remove previous build directory(default: OFF)
 -c: code coverage(default: OFF)
 -g: profiling(default: OFF)
--m: build faiss with MKL(default: OFF)
 -j: use jfrog cache build directory
 
 usage:
-./build.sh -t \${BUILD_TYPE} [-u] [-h] [-g] [-r] [-c] [-k] [-m] [-j]
+./build.sh -t \${BUILD_TYPE} [-u] [-h] [-g] [-r] [-c] [-k] [-j]
                 "
                 exit 0
                 ;;
@@ -87,7 +82,6 @@ if [[ ${MAKE_CLEAN} == "ON" ]]; then
     -DBUILD_COVERAGE=${BUILD_COVERAGE} \
     -DMILVUS_DB_PATH=${DB_PATH} \
     -DMILVUS_ENABLE_PROFILING=${PROFILING} \
-    -DBUILD_FAISS_WITH_MKL=${BUILD_FAISS_WITH_MKL} \
     -DUSE_JFROG_CACHE=${USE_JFROG_CACHE} \
     -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
     ../"

From f195bd7d334171f14a5638a6d00381bc4914185b Mon Sep 17 00:00:00 2001
From: starlord <chxiehust@gmail.com>
Date: Wed, 25 Sep 2019 11:42:25 +0800
Subject: [PATCH 2/2] remove unused option

Former-commit-id: 2594078698d7e570d40f0e72a8f868e1d5a0bd2d
---
 cpp/CMakeLists.txt | 1 -
 1 file changed, 1 deletion(-)

diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index d226a03e61..e7cf83d704 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -43,7 +43,6 @@ endif()
 set(MILVUS_VERSION "${GIT_BRANCH_NAME}")
 string(REGEX MATCH "[0-9]+\\.[0-9]+\\.[0-9]" MILVUS_VERSION "${MILVUS_VERSION}")
 
-set(CLANG_FORMAT_VERSION "6.0")
 find_package(ClangTools)
 if("$ENV{CMAKE_EXPORT_COMPILE_COMMANDS}" STREQUAL "1" OR CLANG_TIDY_FOUND)
   # Generate a Clang compile_commands.json "compilation database" file for use