From 640a49ffb67ec89bc8dd0f1fd5e12cb7c2ff0b00 Mon Sep 17 00:00:00 2001 From: Buqian Zheng Date: Mon, 13 Jan 2025 10:34:57 +0800 Subject: [PATCH] fix: fix chunk cache madvise when sparse raw data is mmaped (#39145) instead of marking as not supported, `ChunkedSparseFloatColumn::DataByteSize` can simply use the impl of super class. issue: https://github.com/milvus-io/milvus/issues/39158 Signed-off-by: Buqian Zheng --- internal/core/src/mmap/ChunkedColumn.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/internal/core/src/mmap/ChunkedColumn.h b/internal/core/src/mmap/ChunkedColumn.h index a75f648460..2195fadf20 100644 --- a/internal/core/src/mmap/ChunkedColumn.h +++ b/internal/core/src/mmap/ChunkedColumn.h @@ -282,14 +282,6 @@ class ChunkedSparseFloatColumn : public ChunkedColumnBase { std::dynamic_pointer_cast(chunk)->Dim()); } - // This is used to advice mmap prefetch, we don't currently support mmap for - // sparse float vector thus not implemented for now. - size_t - DataByteSize() const override { - PanicInfo(ErrorCode::Unsupported, - "ByteSize not supported for sparse float column"); - } - SpanBase Span(int64_t chunk_id) const override { PanicInfo(ErrorCode::Unsupported, @@ -303,7 +295,6 @@ class ChunkedSparseFloatColumn : public ChunkedColumnBase { private: int64_t dim_ = 0; - std::vector> vec_; }; template